Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755389AbdL2Lcm (ORCPT ); Fri, 29 Dec 2017 06:32:42 -0500 Received: from mx2.suse.de ([195.135.220.15]:45105 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754417AbdL2Lcl (ORCPT ); Fri, 29 Dec 2017 06:32:41 -0500 Date: Fri, 29 Dec 2017 12:32:37 +0100 From: Michal Hocko To: Zi Yan Cc: linux-mm@kvack.org, Naoya Horiguchi , "Kirill A. Shutemov" , Vlastimil Babka , Andrew Morton , Andrea Reale , LKML Subject: Re: [RFC PATCH 2/3] mm, migrate: remove reason argument from new_page_t Message-ID: <20171229113237.GA27077@dhcp22.suse.cz> References: <20171207143401.GK20234@dhcp22.suse.cz> <20171208161559.27313-1-mhocko@kernel.org> <20171208161559.27313-3-mhocko@kernel.org> <5881ED15-2645-4D62-B558-9007DA9DE3D5@cs.rutgers.edu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5881ED15-2645-4D62-B558-9007DA9DE3D5@cs.rutgers.edu> User-Agent: Mutt/1.9.2 (2017-12-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1225 Lines: 41 On Tue 26-12-17 21:12:38, Zi Yan wrote: > On 8 Dec 2017, at 11:15, Michal Hocko wrote: [...] > > @@ -1622,7 +1608,6 @@ static int do_pages_move(struct mm_struct *mm, nodemask_t task_nodes, > > } > > chunk_node = NUMA_NO_NODE; > > } > > - err = 0; > > This line can be merged into Patch 1. Or did I miss anything? Yes, I will move it there. > > out_flush: > > /* Make sure we do not overwrite the existing error */ > > err1 = do_move_pages_to_node(mm, &pagelist, chunk_node); > > diff --git a/mm/page_isolation.c b/mm/page_isolation.c > > index 165ed8117bd1..53d801235e22 100644 > > --- a/mm/page_isolation.c > > +++ b/mm/page_isolation.c > > @@ -293,8 +293,7 @@ int test_pages_isolated(unsigned long start_pfn, unsigned long end_pfn, > > return pfn < end_pfn ? -EBUSY : 0; > > } > > > > -struct page *alloc_migrate_target(struct page *page, unsigned long private, > > - int **resultp) > > +struct page *alloc_migrate_target(struct page *page, unsigned long private) > > { > > return new_page_nodemask(page, numa_node_id(), &node_states[N_MEMORY]); > > } > > -- > > 2.15.0 > > Everything else looks good to me. > > Reviewed-by: Zi Yan Thanks! -- Michal Hocko SUSE Labs