Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1750912AbdL2MgU (ORCPT <rfc822;w@1wt.eu>);
        Fri, 29 Dec 2017 07:36:20 -0500
Received: from mail-wr0-f196.google.com ([209.85.128.196]:37906 "EHLO
        mail-wr0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1750708AbdL2MgS (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 29 Dec 2017 07:36:18 -0500
X-Google-Smtp-Source: ACJfBoty3e9mOYhDBO3+bHfrbuTxA8vyzHsE+3D4dxZ8nRjHm5Bavcx4MTOUUDzvztRIkqw1+CMBYan+cpgzsB25vHE=
MIME-Version: 1.0
In-Reply-To: <20171228080437.16933-4-eric@regit.org>
References: <b2cf1e8d-fc1d-4ffb-efec-fafe641c3a49@iogearbox.net>
 <20171228080437.16933-1-eric@regit.org> <20171228080437.16933-4-eric@regit.org>
From: Philippe Ombredanne <pombredanne@nexb.com>
Date: Fri, 29 Dec 2017 13:35:36 +0100
Message-ID: <CAOFm3uHzn9tSexsaSBz9fc1FZqjd7DvSZG7vN4y29PwE_KbLhg@mail.gmail.com>
Subject: Re: [PATCH bpf-next v3 3/3] libbpf: add missing SPDX-License-Identifier
To: Eric Leblond <eric@regit.org>
Cc: daniel@iogearbox.net,
        Alexei Starovoitov <alexei.starovoitov@gmail.com>,
        netdev@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1708
Lines: 71

Eric,

On Thu, Dec 28, 2017 at 9:04 AM, Eric Leblond <eric@regit.org> wrote:
> Signed-off-by: Eric Leblond <eric@regit.org>
> Acked-by: Alexei Starovoitov <ast@kernel.org>
> ---
>  tools/lib/bpf/bpf.c    | 2 ++
>  tools/lib/bpf/bpf.h    | 2 ++
>  tools/lib/bpf/libbpf.c | 2 ++
>  tools/lib/bpf/libbpf.h | 2 ++
>  4 files changed, 8 insertions(+)
>
> diff --git a/tools/lib/bpf/bpf.c b/tools/lib/bpf/bpf.c
> index cdfabbe118cc..9e53dbbca2bd 100644
> --- a/tools/lib/bpf/bpf.c
> +++ b/tools/lib/bpf/bpf.c
> @@ -1,3 +1,5 @@
> +/* SPDX-License-Identifier: LGPL-2.1 */


In a .c file these should using C++-style comments as in //.
As requested by Linus, discussed on list and documented in Thomas doc patches.

> +
>  /*
>   * common eBPF ELF operations.
>   *
> diff --git a/tools/lib/bpf/bpf.h b/tools/lib/bpf/bpf.h
> index 9f44c196931e..8d18fb73d7fb 100644
> --- a/tools/lib/bpf/bpf.h
> +++ b/tools/lib/bpf/bpf.h
> @@ -1,3 +1,5 @@
> +/* SPDX-License-Identifier: LGPL-2.1 */

And this is correct for a .h

> +
>  /*
>   * common eBPF ELF operations.
>   *
> diff --git a/tools/lib/bpf/libbpf.c b/tools/lib/bpf/libbpf.c
> index 5fe8aaa2123e..878e240a681b 100644
> --- a/tools/lib/bpf/libbpf.c
> +++ b/tools/lib/bpf/libbpf.c
> @@ -1,3 +1,5 @@
> +/* SPDX-License-Identifier: LGPL-2.1 */

Use  // here.

> +
>  /*
>   * Common eBPF ELF object loading operations.
>   *
> diff --git a/tools/lib/bpf/libbpf.h b/tools/lib/bpf/libbpf.h
> index e42f96900318..f85906533cdd 100644
> --- a/tools/lib/bpf/libbpf.h
> +++ b/tools/lib/bpf/libbpf.h
> @@ -1,3 +1,5 @@
> +/* SPDX-License-Identifier: LGPL-2.1 */
> +
>  /*
>   * Common eBPF ELF object loading operations.
>   *
> --
> 2.15.1
>


-- 
Cordially
Philippe Ombredanne