Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1750944AbdL2MlJ (ORCPT <rfc822;w@1wt.eu>);
        Fri, 29 Dec 2017 07:41:09 -0500
Received: from mail-wr0-f181.google.com ([209.85.128.181]:43024 "EHLO
        mail-wr0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1750814AbdL2MlH (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 29 Dec 2017 07:41:07 -0500
X-Google-Smtp-Source: ACJfBoshVW5/pWijeno2Shm3WT5YkRuB34yu+GyAKrkMC32f7KRFu6vADnDvnex6QutRgJi4Mbx251ZWBS5VGfvOBYk=
MIME-Version: 1.0
In-Reply-To: <20171226132339.7356-2-jiaxun.yang@flygoat.com>
References: <20171226132339.7356-1-jiaxun.yang@flygoat.com> <20171226132339.7356-2-jiaxun.yang@flygoat.com>
From: Philippe Ombredanne <pombredanne@nexb.com>
Date: Fri, 29 Dec 2017 13:40:26 +0100
Message-ID: <CAOFm3uH8n4Ag+_buYOyBgSa3kzkcAJRpKcHXAk3dBBVNHDiCdw@mail.gmail.com>
Subject: Re: [PATCH 1/7] MIPS: Loongson64: cleanup all cs5536 files to use
 SPDX Identifier
To: Jiaxun Yang <jiaxun.yang@flygoat.com>
Cc: Ralf Baechle <ralf@linux-mips.org>, James Hogan <james.hogan@mips.com>,
        Huacai CHen <chenhc@lemote.com>,
        Linux MIPS <linux-mips@linux-mips.org>,
        LKML <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1050
Lines: 32

On Tue, Dec 26, 2017 at 2:23 PM, Jiaxun Yang <jiaxun.yang@flygoat.com> wrote:
> To reduce unnecessary license text.

<snip>

> diff --git a/arch/mips/loongson64/common/cs5536/cs5536_acc.c b/arch/mips/loongson64/common/cs5536/cs5536_acc.c
> index ab4d6cc57384..ba0474bb4a3d 100644
> --- a/arch/mips/loongson64/common/cs5536/cs5536_acc.c
> +++ b/arch/mips/loongson64/common/cs5536/cs5536_acc.c
> @@ -1,3 +1,5 @@
> +/* SPDX-License-Identifier: GPL-2.0 */

Please use  // comment in .c files as requested by Linus and discussed on list.
This is also documented in Thomas doc patches.
This applies to the whole patch set.

<snip>

> diff --git a/arch/mips/loongson64/common/cs5536/cs5536_isa.c b/arch/mips/loongson64/common/cs5536/cs5536_isa.c
> index 924be39e7733..c358c0755eff 100644
> --- a/arch/mips/loongson64/common/cs5536/cs5536_isa.c
> +++ b/arch/mips/loongson64/common/cs5536/cs5536_isa.c
> @@ -1,3 +1,5 @@
> +/* SPDX-License-Identifier: GPL-2.0 */

And this is the correct comment style for .h files.

Thanks!

-- 
Cordially
Philippe Ombredanne