Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1750993AbdL2MuB (ORCPT <rfc822;w@1wt.eu>);
        Fri, 29 Dec 2017 07:50:01 -0500
Received: from mail-wm0-f66.google.com ([74.125.82.66]:35017 "EHLO
        mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1750744AbdL2Mt7 (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 29 Dec 2017 07:49:59 -0500
X-Google-Smtp-Source: ACJfBosMc/d2bpcFJEHRugHiognDUUWJLdxifGQ51bruQxQ8obmh6elWwPB0QRWYGUg3lQI3l1qpmg==
Date: Fri, 29 Dec 2017 13:49:55 +0100
From: Ingo Molnar <mingo@kernel.org>
To: Mathieu Malaterre <malat@debian.org>
Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>,
        Peter Zijlstra <peterz@infradead.org>, Ingo Molnar <mingo@redhat.com>,
        Arnaldo Carvalho de Melo <acme@kernel.org>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Jiri Olsa <jolsa@redhat.com>, Namhyung Kim <namhyung@kernel.org>,
        linux-kernel@vger.kernel.org,
        Linus Torvalds <torvalds@linux-foundation.org>,
        Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH 3/3] perf/core: Move inline keyword at the beginning of
 declaration
Message-ID: <20171229124955.w2fntu777rw4qp4v@gmail.com>
References: <20171226140922.16699-1-malat@debian.org>
 <20171228121509.wq7mdeh3v4jcbjn2@gmail.com>
 <CA+7wUszznjvTN9SAofB7BMOiXrYb_5TZhhsJ5QMAmfoTSybNUg@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <CA+7wUszznjvTN9SAofB7BMOiXrYb_5TZhhsJ5QMAmfoTSybNUg@mail.gmail.com>
User-Agent: NeoMutt/20170609 (1.8.3)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 938
Lines: 33


* Mathieu Malaterre <malat@debian.org> wrote:

> Hi Ingo,
> 
> On Thu, Dec 28, 2017 at 1:15 PM, Ingo Molnar <mingo@kernel.org> wrote:
> >
> > * Mathieu Malaterre <malat@debian.org> wrote:
> >
> >> Fix non-fatal warnings such as:
> >>
> >> kernel/events/ring_buffer.c:116:1: warning: ‘inline’ is not at beginning of declaration [-Wold-style-declaration]
> >>  static int __always_inline
> >>  ^~~~~~
> >>
> >> Signed-off-by: Mathieu Malaterre <malat@debian.org>
> >> ---
> >>  kernel/events/ring_buffer.c | 6 +++---
> >>  1 file changed, 3 insertions(+), 3 deletions(-)
> >
> > Hm, never saw this warning before - is this a newly default GCC warning, or some
> > distro CFLAGS build that enables it?
> 
> Nope. Just compiling vanilla kernel with default options, defconfig
> was pmac32. I used W=1.

"W=1" is not a default build variant - it enables -Wall...

This absolutely needs to be spelled out in the changelog!

Thanks,

	Ingo