Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751237AbdL2OuL (ORCPT ); Fri, 29 Dec 2017 09:50:11 -0500 Received: from mail-wr0-f195.google.com ([209.85.128.195]:41391 "EHLO mail-wr0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750821AbdL2OuI (ORCPT ); Fri, 29 Dec 2017 09:50:08 -0500 X-Google-Smtp-Source: ACJfBotBm+xDijAnq/+WXnfR1vuRWMy/eGZpuSNOn2KfKfrCDyVtCGb+gx/Y6x+SyrW9NC6Hs3dZEw== Date: Fri, 29 Dec 2017 15:50:02 +0100 From: Philippe Loctaux To: Ozgur Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, loctauxphilippe@gmail.com Subject: Re: [PATCH 2/2] Staging: most: aim-sound: sound.c: removed unnecessary parentheses Message-ID: <20171229144957.GA16123@parch.localdomain> References: <20171228230650.12973-1-loctauxphilippe@gmail.com> <20171228230650.12973-3-loctauxphilippe@gmail.com> <227541514503196@web8o.yandex.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <227541514503196@web8o.yandex.ru> User-Agent: Mutt/1.9.2 (2017-12-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 489 Lines: 15 On Fri, Dec 29, 2017 at 02:19:56AM +0300, Ozgur wrote: > I think this patch is not good, the code will not work. Please should understand in && operator and () why used with C. hi, this patch should work, since it compiles and passes checkpatch. the reason why i removed the () is because of the && operator, it works without the need of having () around the statments, which makes the code simpler to read. have a nice day. -phil loctauxphilippe@gmail.com https://philippeloctaux.com