Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751372AbdL2Pam (ORCPT ); Fri, 29 Dec 2017 10:30:42 -0500 Received: from mail-qk0-f196.google.com ([209.85.220.196]:41814 "EHLO mail-qk0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751020AbdL2Pak (ORCPT ); Fri, 29 Dec 2017 10:30:40 -0500 X-Google-Smtp-Source: ACJfBot/Z+jK2da9Dd+cX8RlxlSUuEmYEru7PjD2ans67bTTyjnz67t6i58x/rX+z4EeHLpHL9S+jqprgW9ieFz2XHM= MIME-Version: 1.0 In-Reply-To: <1514556006-23293-1-git-send-email-mastichi@gmail.com> References: <1514556006-23293-1-git-send-email-mastichi@gmail.com> From: Andy Shevchenko Date: Fri, 29 Dec 2017 17:30:39 +0200 Message-ID: Subject: Re: [PATCH v2] iio: adc: max9611: fix module auto-loading To: Dmitry Mastykin Cc: Jonathan Cameron , Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald-Stadler , Jacopo Mondi , Dan Carpenter , Rob Herring , linux-iio@vger.kernel.org, Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1451 Lines: 50 On Fri, Dec 29, 2017 at 3:59 PM, Dmitry Mastykin wrote: > The simplest fix is to move to ->probe_new() since the driver is not > used out of DT/ACPI enumeration. > Suggested-by: Andy Shevchenko I suppose, and Reviewed-by: Andy Shevchenko Thanks! > Signed-off-by: Dmitry Mastykin > --- > drivers/iio/adc/max9611.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/drivers/iio/adc/max9611.c b/drivers/iio/adc/max9611.c > index b1dd17c..ce0115a 100644 > --- a/drivers/iio/adc/max9611.c > +++ b/drivers/iio/adc/max9611.c > @@ -523,8 +523,7 @@ static const struct of_device_id max9611_of_table[] = { > }; > > MODULE_DEVICE_TABLE(of, max9611_of_table); > -static int max9611_probe(struct i2c_client *client, > - const struct i2c_device_id *id) > +static int max9611_probe(struct i2c_client *client) > { > const char * const shunt_res_prop = "shunt-resistor-micro-ohms"; > const struct device_node *of_node = client->dev.of_node; > @@ -576,7 +575,7 @@ static struct i2c_driver max9611_driver = { > .owner = THIS_MODULE, > .of_match_table = max9611_of_table, > }, > - .probe = max9611_probe, > + .probe_new = max9611_probe, > }; > module_i2c_driver(max9611_driver); > > -- > 2.7.4 > -- With Best Regards, Andy Shevchenko