Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751765AbdL2Ry4 (ORCPT ); Fri, 29 Dec 2017 12:54:56 -0500 Received: from mail.kernel.org ([198.145.29.99]:34714 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751277AbdL2Ryy (ORCPT ); Fri, 29 Dec 2017 12:54:54 -0500 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B45B3218B1 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=jic23@kernel.org Date: Fri, 29 Dec 2017 17:54:48 +0000 From: Jonathan Cameron To: Andy Shevchenko Cc: Dmitry Mastykin , Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald-Stadler , Jacopo Mondi , Dan Carpenter , Rob Herring , linux-iio@vger.kernel.org, Linux Kernel Mailing List Subject: Re: [PATCH v2] iio: adc: max9611: fix module auto-loading Message-ID: <20171229175449.760e734d@archlinux> In-Reply-To: References: <1514556006-23293-1-git-send-email-mastichi@gmail.com> X-Mailer: Claws Mail 3.15.1-dirty (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1707 Lines: 55 On Fri, 29 Dec 2017 17:30:39 +0200 Andy Shevchenko wrote: > On Fri, Dec 29, 2017 at 3:59 PM, Dmitry Mastykin wrote: > > The simplest fix is to move to ->probe_new() since the driver is not > > used out of DT/ACPI enumeration. > > > > Suggested-by: Andy Shevchenko > > I suppose, and > > Reviewed-by: Andy Shevchenko I'm a little confused. Why does this now make module autoloading work where it previously didn't? Jonathan > > Thanks! > > > Signed-off-by: Dmitry Mastykin > > --- > > drivers/iio/adc/max9611.c | 5 ++--- > > 1 file changed, 2 insertions(+), 3 deletions(-) > > > > diff --git a/drivers/iio/adc/max9611.c b/drivers/iio/adc/max9611.c > > index b1dd17c..ce0115a 100644 > > --- a/drivers/iio/adc/max9611.c > > +++ b/drivers/iio/adc/max9611.c > > @@ -523,8 +523,7 @@ static const struct of_device_id max9611_of_table[] = { > > }; > > > > MODULE_DEVICE_TABLE(of, max9611_of_table); > > -static int max9611_probe(struct i2c_client *client, > > - const struct i2c_device_id *id) > > +static int max9611_probe(struct i2c_client *client) > > { > > const char * const shunt_res_prop = "shunt-resistor-micro-ohms"; > > const struct device_node *of_node = client->dev.of_node; > > @@ -576,7 +575,7 @@ static struct i2c_driver max9611_driver = { > > .owner = THIS_MODULE, > > .of_match_table = max9611_of_table, > > }, > > - .probe = max9611_probe, > > + .probe_new = max9611_probe, > > }; > > module_i2c_driver(max9611_driver); > > > > -- > > 2.7.4 > > > > >