Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751759AbdL2SnN (ORCPT ); Fri, 29 Dec 2017 13:43:13 -0500 Received: from mout.web.de ([212.227.15.3]:50439 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751159AbdL2SnL (ORCPT ); Fri, 29 Dec 2017 13:43:11 -0500 Subject: Re: [0/5] video-SMSC UFX: Adjustments for five function implementations To: Bartlomiej Zolnierkiewicz , linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org Cc: Steve Glendinning , LKML , kernel-janitors@vger.kernel.org References: <1736749.UIs06O4xc5@amdc3058> From: SF Markus Elfring Message-ID: <265c7022-d12f-bcbe-c6f0-452ba3f73744@users.sourceforge.net> Date: Fri, 29 Dec 2017 19:43:00 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 MIME-Version: 1.0 In-Reply-To: <1736749.UIs06O4xc5@amdc3058> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K0:0CNA1tnvVA8CriLdIJogAyu2RdMp88D0VLXrzTOeQaAs4M+wp4V bYYPKPVQma7/4Ft0cONxri8nOhSJ4PMpyzsGO6b9bwvSXmiu94Uwj2aTmrBhb9TKu/vtPuS zVWuqWhselNas7BEg88DrOMzUxQtXsyJ9brw5aIgkzFIlPIKIADQig75ApQXdLD4FLalQMf 0G4esq8p84EY/w11V1J5A== X-UI-Out-Filterresults: notjunk:1;V01:K0:AG/epksqbfw=:qX5Gz+VlbTU2VhsVvZEHtz oeapb5KUwPIFsPJWTiepWESCygFSEevcwlfw/rAg2Ww0glprFXylALfGEcIbEFluKYopCUamS 4S5108WDyEasQmIh33VBJD9r4lINc8FRtJ7ok5tpN47XuVFDo8X6OLMaBVdqqxiHcFO/vM3v8 Ybo8tc9o27CHaT3MRz4rC5je7rAbbUtLsSSszXssG+gsyGk+pQ6Vzjh+/ibDuczrEMzhRCVbF x1uEsKGpEMYIYzAaslsHy+ljFxH7SKEC2Sm128AYVA9InVIuwwaaa9NsxnemkHgAo0K7o7ic5 KmBULlOW9/NmbLlm53Ij5brbmZy6HlpIJYeuhqNR5WMnYaTBKg+0r9XSDEFYQLgAw5+ULzmYL K0eE9ETkkEodqI+sHOjPrspv7NUa50euLZOIPVn0As3nS00E0o7vffnrpaAmU3hNVUuAg/zWt E5nilJtxGHwW3wkNxlqM9vImS7WnqjgO9khyRniOiGdm58i4j1I4CKLgPm3va1wyhoZ14GB94 OsNlpoAQICfk80ODQUN7BT7hKZXo5lpIS4vPsUpL4A5M2zdolVI+k+L3E9dGUBIzh9llH5x8v ES4RKNJvgyD+SqVIsCcJ5OjcW7ZWtsEOKR56YVfItdNyPPd8ZdompnPQSS4q6POTDLi5ERxcL g1zNg6iWZOmNXEwcwZaUPVqVtqHw4OQXCsn5+OK2WlHhTsg9Betkc07fxoXjmYYh+G5GHZg/H c3qdgETM1dIVeIDgLOttShAsMQtE+8JzQdryz6vtoR1O2M+WKVj2XEnSgmLofHkqc/zircLIe w3/5ZGwCIbjrH8TqkyDxMJNjdGhXt7xKFtwUWVUtLJAl9q8WKc= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 767 Lines: 28 >> Delete an error message for a failed memory allocation in two functions > > This patch removes the information about the device for which the allocation fails. Should a Linux allocation failure report be sufficient here? >> Less checks in ufx_usb_probe() after error detection > > This patch depends on the earlier patch (which is not being merged) Partly, yes. > so please re-base it if you want it to be applied. Would you dare to pick another change possibility up from a patch hunk? >> Adjust three checks for null pointers > > This patch contains unrelated change ({} braces addition) which should be dropped. I presented such an update approach so that warnings from the script “checkpatch.pl” will be fixed together. Regards, Markus