Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751799AbdL2Tew (ORCPT ); Fri, 29 Dec 2017 14:34:52 -0500 Received: from mail-wm0-f44.google.com ([74.125.82.44]:46112 "EHLO mail-wm0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751125AbdL2Tev (ORCPT ); Fri, 29 Dec 2017 14:34:51 -0500 X-Google-Smtp-Source: ACJfBotMv0/4nPg9My7spDe4F7p+bvQ86/IODuedJVT2f78VWOnODyv59Q1I1kZjiG2iXgfdZPzBgw== Subject: Re: [PATCH] arch/x86/boot: sizeof macro To: Andy Shevchenko Cc: "H. Peter Anvin" , Thomas Gleixner , x86@kernel.org, Linux Kernel Mailing List References: <20171229183015.7772-1-cpu808694@gmail.com> From: hacku Message-ID: <9561caf7-0a7d-3bc1-fc26-fff74707032c@gmail.com> Date: Fri, 29 Dec 2017 20:34:47 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 525 Lines: 18 Coding style for sizeof . If you check this file with checkpatch.pl you will see warning on this line. Yes, sorry I didn't mark this change as a coding style issue. best regards, Saidgani. On 12/29/2017 07:41 PM, Andy Shevchenko wrote: > On Fri, Dec 29, 2017 at 8:30 PM, Saidgani Musaev wrote: > > No changelog, no explanation why... > No SoB tag... > >> - ireg.cx = sizeof buf; >> + ireg.cx = sizeof(buf); > sizeof is operator, not a function. > So, what are you trying to achieve? >