Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751739AbdL2TqU (ORCPT ); Fri, 29 Dec 2017 14:46:20 -0500 Received: from mail-wr0-f193.google.com ([209.85.128.193]:35956 "EHLO mail-wr0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751318AbdL2TqS (ORCPT ); Fri, 29 Dec 2017 14:46:18 -0500 X-Google-Smtp-Source: ACJfBouN0gW8Psve1VK3X0Zcu9Gq8wM8OemAJp6A3ASVtLTNuN51V4+iEZGgKYshh0PG4mrU6xPVfg== Date: Fri, 29 Dec 2017 20:46:14 +0100 From: Ingo Molnar To: Andy Shevchenko Cc: Saidgani Musaev , "H. Peter Anvin" , Thomas Gleixner , x86@kernel.org, Linux Kernel Mailing List Subject: Re: [PATCH] arch/x86/boot: sizeof macro Message-ID: <20171229194614.3iku5zg5oglrd2cl@gmail.com> References: <20171229183015.7772-1-cpu808694@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170609 (1.8.3) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 543 Lines: 25 * Andy Shevchenko wrote: > On Fri, Dec 29, 2017 at 8:30 PM, Saidgani Musaev wrote: > > No changelog, no explanation why... > No SoB tag... > > > - ireg.cx = sizeof buf; > > + ireg.cx = sizeof(buf); > > sizeof is operator, not a function. > So, what are you trying to achieve? That's true, but in the kernel coding style we use it as a function: triton:~/tip> git grep 'sizeof(' | wc -l 116570 triton:~/tip> git grep 'sizeof [:alnum:]' | wc -l 177 Thanks, Ingo