From: Hans-Peter Jansen <hpj@urpla.net>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: 4.14.9 broke nvidia 384.98 kernel module
Date: Sat, 30 Dec 2017 13:36:33 +0100
Message-ID: <3907598.31jH6naT2q@xrated>
User-Agent: KMail/4.14.10 (Linux/4.14.6-3-default; KDE/4.14.28; x86_64; ; )
In-Reply-To: <20171229092356.GA19798@kroah.com>
References: <11951640.VTVQv5kjZe@xrated> <20171229092356.GA19798@kroah.com>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="nextPart2962170.LM5udgoD9k"
Content-Transfer-Encoding: 7Bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1902
Lines: 55

This is a multi-part message in MIME format.

--nextPart2962170.LM5udgoD9k
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"

On Freitag, 29. Dezember 2017 10:23:56 Greg KH wrote:
> On Fri, Dec 29, 2017 at 02:08:08AM +0100, Hans-Peter Jansen wrote:
> > Hi Greg,
> > 
> > I know, everybody hates NVidia and their proprietary stuff around here.
> > 
> > Anyway, I wanted to let you and followers of 4.14 know, that changes
> > between> 
> > 4.14.8 and 4.14.9 broke both current nvidia kernel drivers. See:
> > 	https://devtalk.nvidia.com/default/topic/1028016/linux/patch-for-compilin
> > 	g-v384-98-modules-with-linux-v4-14-9-/
> Should be fixed in 4.14.10-rc1, right?

Hmm, building with 4.14.10 without the patch results in:

[   19s] + make -f Makefile nv-linux.o SYSSRC=/lib/modules/4.14.10-3-
default/source SYSOUT=/usr/src/linux-obj/x86_64/default
[...]
[   88s] /home/abuild/rpmbuild/BUILD/nvidia-
gfxG04-384.98/obj/default/384.98/nvidia-uvm/uvm8_va_block.c:8771:41: error: 
implicit declaration of function 'task_stack_page' [-Werror=implicit-function-
declaration]

With the patch applied (attached for reference), the build succeeds..

Cheers,
Pete
--nextPart2962170.LM5udgoD9k
Content-Disposition: attachment; filename="nvidia-gfxG04-kernel-4.14.9.patch"
Content-Transfer-Encoding: 7Bit
Content-Type: text/x-patch; charset="UTF-8";
 name="nvidia-gfxG04-kernel-4.14.9.patch"

diff -durN nvidia-384-orig/nvidia-uvm/uvm8_va_block.c nvidia-384/nvidia-uvm/uvm8_va_block.c
--- a/kernel/nvidia-uvm/uvm8_va_block.c 2017-12-26 11:20:17.097715622 +0100
+++ b/kernel/nvidia-uvm/uvm8_va_block.c 2017-12-26 11:20:29.674381760 +0100
@@ -36,6 +36,10 @@
 #include "uvm8_perf_prefetch.h"
 #include "uvm8_mem.h"
 
+#if LINUX_VERSION_CODE >= KERNEL_VERSION(4,14,9)
+#include <linux/sched/task_stack.h>
+#endif
+
 typedef enum
 {
     BLOCK_PTE_OP_MAP,

--nextPart2962170.LM5udgoD9k--