Date: Sat, 30 Dec 2017 14:14:57 +0100 (CET)
From: Jiri Kosina <jikos@kernel.org>
To: =?ISO-8859-15?Q?Toralf_F=F6rster?= <toralf.foerster@gmx.de>
cc: Alexander Tsoy <alexander@tsoy.me>,
        Andy Lutomirski <luto@amacapital.net>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        stable <stable@vger.kernel.org>,
        Linux Kernel <linux-kernel@vger.kernel.org>,
        the arch/x86 maintainers <x86@kernel.org>, jpoimboe@redhat.com
Subject: Re: 4.14.9 doesn't boot (regression)
In-Reply-To: <755e371f-576c-419d-b8fe-66232e8de680@gmx.de>
Message-ID: <alpine.LRH.2.00.1712301404570.1449@gjva.wvxbf.pm>
References: <b8b49443-e43b-7253-78c9-23a0b1632a3b@gmx.de> <CA+55aFz+moL9zem-gGnRtGSzYV0yL+GoA=3+XrUZy9t=cmhBhw@mail.gmail.com> <33249a35-7d6a-f0f3-5a98-e6474f9366e3@gmx.de> <CA+55aFyJiCT=Mnn5RUMiYRXddi_eSdVTpobEKNoHzYXsos_6pw@mail.gmail.com>
 <a591188f-021b-6d0a-6261-28fa83d161e1@gmx.de> <CA+55aFwfHEr1mSmHyvmSeFJvxMnpN=NPgJ21zEOkDPvZ2y4wXg@mail.gmail.com> <7A0A9B37-20FF-4B17-B4F5-D8B999269FC4@amacapital.net> <1514596414.28262.22.camel@tsoy.me> <755e371f-576c-419d-b8fe-66232e8de680@gmx.de>
User-Agent: Alpine 2.00 (LRH 1167 2008-08-23)
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=ISO-8859-15
Content-Transfer-Encoding: 8BIT
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1368
Lines: 38

On Sat, 30 Dec 2017, Toralf F?rster wrote:

> This made the issue go away :
> 
> diff --git a/Makefile b/Makefile
> index ac8c441866b7..11a12947c550 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -414,7 +414,7 @@ LINUXINCLUDE    := \
>  
>  KBUILD_AFLAGS   := -D__ASSEMBLY__
>  KBUILD_CFLAGS   := -Wall -Wundef -Wstrict-prototypes -Wno-trigraphs \
> -                  -fno-strict-aliasing -fno-common -fshort-wchar \
> +                  -fno-strict-aliasing -fno-common -fshort-wchar -fstack-check=no \
>                    -Werror-implicit-function-declaration \
>                    -Wno-format-security \
>                    -std=gnu89
> 
> But this doesn't solve the root cause, right ? So if the root cause is 
> "Gentoo hardened GCC is broken" please just let me know this - FWIW I'm 
> in #gentoo-dev on freenode.

-fstack-check for kernel is never going to work properly.

That option is purely for userspace, and assumes all the logic around 
'stack guard gap' and the auto-growing semantics being in place; which is 
there for user stack VMA, but definitely not for kernel stack.

It's probably the "hardened" flavor of your distro trying to push 
'-fstack-check' to everything it compiles; so I actually think the 
Makefile patch, sanitizing CFLAGS by force-disabling -fstack-check is 
exactly what we should be doing.

Thanks,

-- 
Jiri Kosina
SUSE Labs