Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751053AbdLaLVJ (ORCPT <rfc822;w@1wt.eu>);
        Sun, 31 Dec 2017 06:21:09 -0500
Received: from mail-wr0-f196.google.com ([209.85.128.196]:42212 "EHLO
        mail-wr0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1750854AbdLaLVH (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Sun, 31 Dec 2017 06:21:07 -0500
X-Google-Smtp-Source: ACJfBosyE/cuE1S9Kn/I2pbt6WchNnHB83G5xRqqfLB688jF/c1bcEux1R/0WHkAYcgMj0rqfLtIuZnvYJmjsbbOKlY=
MIME-Version: 1.0
In-Reply-To: <20171230204116.30871-3-eric@regit.org>
References: <9ec8def5-a24f-a4ff-d0ae-fb8f11e4acdc@lab.ntt.co.jp>
 <20171230204116.30871-1-eric@regit.org> <20171230204116.30871-3-eric@regit.org>
From: Philippe Ombredanne <pombredanne@nexb.com>
Date: Sun, 31 Dec 2017 12:20:25 +0100
Message-ID: <CAOFm3uE7wvk_9MuesAnSzW3JznwU4sbEU-vjW7JARrrKLPdQJw@mail.gmail.com>
Subject: Re: [PATCH bpf-next v4 2/3] libbpf: add error reporting in XDP
To: Eric Leblond <eric@regit.org>
Cc: daniel@iogearbox.net, Toshiaki Makita <makita.toshiaki@lab.ntt.co.jp>,
        Alexei Starovoitov <alexei.starovoitov@gmail.com>,
        netdev@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1064
Lines: 36

On Sat, Dec 30, 2017 at 9:41 PM, Eric Leblond <eric@regit.org> wrote:
> Parse netlink ext attribute to get the error message returned by
> the card. Code is partially take from libnl.
>
> Signed-off-by: Eric Leblond <eric@regit.org>
> Acked-by: Alexei Starovoitov <ast@kernel.org>

<snip>

> --- /dev/null
> +++ b/tools/lib/bpf/nlattr.c
> @@ -0,0 +1,187 @@
> +// SPDX-License-Identifier: LGPL-2.1
> +
> +/*
> + * NETLINK      Netlink attributes
> + *
> + *     This library is free software; you can redistribute it and/or
> + *     modify it under the terms of the GNU Lesser General Public
> + *     License as published by the Free Software Foundation version 2.1
> + *     of the License.
> + *
> + * Copyright (c) 2003-2013 Thomas Graf <tgraf@suug.ch>
> + */

Do you think you could get an ack or signoff from the author
(i.e.Thomas Graf)  to get a more streamlined thing such as this:

> +// SPDX-License-Identifier: LGPL-2.1
> +// NETLINK      Netlink attributes
> +// Copyright (c) 2003-2013 Thomas Graf <tgraf@suug.ch>


-- 
Cordially
Philippe Ombredanne