Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751330AbdLaLsb (ORCPT ); Sun, 31 Dec 2017 06:48:31 -0500 Received: from mail-qt0-f193.google.com ([209.85.216.193]:33912 "EHLO mail-qt0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750936AbdLaLsa (ORCPT ); Sun, 31 Dec 2017 06:48:30 -0500 X-Google-Smtp-Source: ACJfBotKD0LTSMC3GGKbT+XhA0f8D+dil8200vhgJRKnbb1X0hiCJ8zzVywGqf2gYj6vctZ6NlqgQjNDHsEprW6UrEI= MIME-Version: 1.0 In-Reply-To: <20171229194614.3iku5zg5oglrd2cl@gmail.com> References: <20171229183015.7772-1-cpu808694@gmail.com> <20171229194614.3iku5zg5oglrd2cl@gmail.com> From: Andy Shevchenko Date: Sun, 31 Dec 2017 13:48:28 +0200 Message-ID: Subject: Re: [PATCH] arch/x86/boot: sizeof macro To: Ingo Molnar Cc: Saidgani Musaev , "H. Peter Anvin" , Thomas Gleixner , x86@kernel.org, Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 556 Lines: 18 On Fri, Dec 29, 2017 at 9:46 PM, Ingo Molnar wrote: > * Andy Shevchenko wrote: >> > - ireg.cx = sizeof buf; >> > + ireg.cx = sizeof(buf); >> >> sizeof is operator, not a function. >> So, what are you trying to achieve? > > That's true, but in the kernel coding style we use it as a function: Yeah, the question is do we need to change all those 177 occurrences at all? Or perhaps it might be an opportunity during some other changes to certain users... -- With Best Regards, Andy Shevchenko