Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751274AbeAAJzj (ORCPT + 1 other); Mon, 1 Jan 2018 04:55:39 -0500 Received: from asavdk4.altibox.net ([109.247.116.15]:38327 "EHLO asavdk4.altibox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751059AbeAAJzf (ORCPT ); Mon, 1 Jan 2018 04:55:35 -0500 Date: Mon, 1 Jan 2018 10:55:30 +0100 From: Sam Ravnborg To: Nicholas Mc Guire Cc: Masahiro Yamada , Lukas Bulwahn , Linux Kbuild mailing list , sil2review@lists.osadl.org, Michal Marek , Linux Kernel Mailing List Subject: Re: [PATCH v2] fixdep: exit with error code in error branches of do_config_file() Message-ID: <20180101095530.GA6547@ravnborg.org> References: <1513801623-19069-1-git-send-email-lukas.bulwahn@gmail.com> <1513883429-9527-1-git-send-email-lukas.bulwahn@gmail.com> <20171231154548.GA27372@osadl.at> <20180101093121.GA7228@osadl.at> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180101093121.GA7228@osadl.at> User-Agent: Mutt/1.5.21 (2010-09-15) X-CMAE-Score: 0 X-CMAE-Analysis: v=2.2 cv=eqGd9chX c=1 sm=1 tr=0 a=ddpE2eP9Sid01c7MzoqXPA==:117 a=ddpE2eP9Sid01c7MzoqXPA==:17 a=kj9zAlcOel0A:10 a=pppjYhGmnseiEONSZr0A:9 a=CjuIK1q_8ugA:10 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: > > > And would that file be acceptable if it were actually empty There have been cases with empty files in the source tree. And it is not the job of fixdep to do anything special about them. fixdep shall do what it is requested to do, and not more than that. Sam