Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751243AbeAAKEe (ORCPT + 1 other); Mon, 1 Jan 2018 05:04:34 -0500 Received: from mail-io0-f171.google.com ([209.85.223.171]:33638 "EHLO mail-io0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751060AbeAAKEc (ORCPT ); Mon, 1 Jan 2018 05:04:32 -0500 X-Google-Smtp-Source: ACJfBourw1hB1Wj9LYbyuTLYXSE53XXcr7tMuEKqeWEE1o9pVAJ2Oirhb7RtAOL6y+xKE/kEGhscf4aDHW/78pV16/8= MIME-Version: 1.0 In-Reply-To: <20171231191836.GA20455@lunn.ch> References: <1514721520-18964-1-git-send-email-mw@semihalf.com> <1514721520-18964-5-git-send-email-mw@semihalf.com> <20171231191836.GA20455@lunn.ch> From: Marcin Wojtas Date: Mon, 1 Jan 2018 11:04:30 +0100 Message-ID: Subject: Re: [net-next: PATCH v2 4/5] net: mvpp2: use device_*/fwnode_* APIs instead of of_* To: Andrew Lunn Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, netdev , linux-acpi@vger.kernel.org, Graeme Gregory , "David S. Miller" , Russell King - ARM Linux , "Rafael J. Wysocki" , Florian Fainelli , =?UTF-8?Q?Antoine_T=C3=A9nart?= , Thomas Petazzoni , =?UTF-8?Q?Gregory_Cl=C3=A9ment?= , Ezequiel Garcia , nadavh@marvell.com, Neta Zur Hershkovits , Ard Biesheuvel , Grzegorz Jaszczyk , Tomasz Nowicki Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: Hi Andrew, 2017-12-31 20:18 GMT+01:00 Andrew Lunn : > On Sun, Dec 31, 2017 at 12:58:39PM +0100, Marcin Wojtas wrote: > Hi Marcin > >> Because there is no equivalent for for_each_available_child_of_node(), >> use device_for_each_child_node() and check the port availability >> inside the mvpp2_port_probe() routine. > > Could device_each_available_child_node() be added? I guess this will > not be the last driver converted in this way, and having that macro > will help with future ports. > Sure, I can add it in the next round. Thanks, Marcin