Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751316AbeAAUzh (ORCPT + 1 other); Mon, 1 Jan 2018 15:55:37 -0500 Received: from 109-183-129-149.tmcz.cz ([109.183.129.149]:38318 "EHLO leontynka.twibright.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750923AbeAAUzf (ORCPT ); Mon, 1 Jan 2018 15:55:35 -0500 X-Greylist: delayed 1952 seconds by postgrey-1.27 at vger.kernel.org; Mon, 01 Jan 2018 15:55:35 EST Date: Mon, 1 Jan 2018 21:23:00 +0100 (CET) From: Mikulas Patocka X-X-Sender: mikulas@leontynka To: Julia Lawall cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 12/12] hpfs: drop unneeded newline In-Reply-To: <1514386305-7402-13-git-send-email-Julia.Lawall@lip6.fr> Message-ID: References: <1514386305-7402-1-git-send-email-Julia.Lawall@lip6.fr> <1514386305-7402-13-git-send-email-Julia.Lawall@lip6.fr> User-Agent: Alpine 2.02 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On Wed, 27 Dec 2017, Julia Lawall wrote: > hpfs_error prints a newline at the end of the message string, so the > message string does not need to include a newline explicitly. Done > using Coccinelle. > > Signed-off-by: Julia Lawall Reviewed-by: Mikulas Patocka > --- > fs/hpfs/dnode.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/fs/hpfs/dnode.c b/fs/hpfs/dnode.c > index a4ad18a..fc1809b 100644 > --- a/fs/hpfs/dnode.c > +++ b/fs/hpfs/dnode.c > @@ -914,7 +914,8 @@ struct hpfs_dirent *map_dirent(struct inode *inode, dnode_secno dno, > struct hpfs_dirent *de_end; > int c1, c2 = 0; > > - if (!S_ISDIR(inode->i_mode)) hpfs_error(inode->i_sb, "map_dirent: not a directory\n"); > + if (!S_ISDIR(inode->i_mode)) > + hpfs_error(inode->i_sb, "map_dirent: not a directory"); > again: > if (hpfs_sb(inode->i_sb)->sb_chk) > if (hpfs_stop_cycles(inode->i_sb, dno, &c1, &c2, "map_dirent")) return NULL; > >