Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753354AbeABAp2 (ORCPT + 1 other); Mon, 1 Jan 2018 19:45:28 -0500 Received: from mail-io0-f195.google.com ([209.85.223.195]:43163 "EHLO mail-io0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752868AbeABAp0 (ORCPT ); Mon, 1 Jan 2018 19:45:26 -0500 X-Google-Smtp-Source: ACJfBotjptfF6mtvlwpi/caS+PNf4DwpzQKvmoJtYA7iDHF1DgLvAg6f+6yzhxBiLmOg5p6Oy1dCrkmO7jRUAIr23OU= MIME-Version: 1.0 In-Reply-To: <1514847495-29681-1-git-send-email-pbonzini@redhat.com> References: <1514847495-29681-1-git-send-email-pbonzini@redhat.com> From: Jim Mattson Date: Mon, 1 Jan 2018 16:45:24 -0800 Message-ID: Subject: Re: [PATCH] KVM: nVMX: remove unnecessary vmwrite from L2->L1 vmexit To: Paolo Bonzini Cc: LKML , kvm list Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: Reviewed-by: Jim Mattson On Mon, Jan 1, 2018 at 2:58 PM, Paolo Bonzini wrote: > The POSTED_INTR_NV field is constant (though it differs between the vmcs01 and > vmcs02), there is no need to reload it on vmexit to L1. > > Signed-off-by: Paolo Bonzini > --- > arch/x86/kvm/vmx.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c > index e6223fe8faa1..1e184830a295 100644 > --- a/arch/x86/kvm/vmx.c > +++ b/arch/x86/kvm/vmx.c > @@ -11610,9 +11610,6 @@ static void load_vmcs12_host_state(struct kvm_vcpu *vcpu, > */ > vmx_flush_tlb(vcpu, true); > } > - /* Restore posted intr vector. */ > - if (nested_cpu_has_posted_intr(vmcs12)) > - vmcs_write16(POSTED_INTR_NV, POSTED_INTR_VECTOR); > > vmcs_write32(GUEST_SYSENTER_CS, vmcs12->host_ia32_sysenter_cs); > vmcs_writel(GUEST_SYSENTER_ESP, vmcs12->host_ia32_sysenter_esp); > -- > 1.8.3.1 >