Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752905AbeABBkW (ORCPT + 1 other); Mon, 1 Jan 2018 20:40:22 -0500 Received: from szxga04-in.huawei.com ([45.249.212.190]:3210 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751917AbeABBkV (ORCPT ); Mon, 1 Jan 2018 20:40:21 -0500 From: Wei Yongjun To: Srinivas Kandagatla , Sagar Dharia CC: Wei Yongjun , , Subject: [PATCH -next] slimbus: Use GFP_ATOMIC under spin lock Date: Tue, 2 Jan 2018 01:45:54 +0000 Message-ID: <1514857554-83836-1-git-send-email-weiyongjun1@huawei.com> X-Mailer: git-send-email 1.8.3.1 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 X-Originating-IP: [10.175.113.25] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: A spin lock is taken here so we should use GFP_ATOMIC. Fixes: afbdcc7c384b ("slimbus: Add messaging APIs to slimbus framework") Signed-off-by: Wei Yongjun --- drivers/slimbus/messaging.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/slimbus/messaging.c b/drivers/slimbus/messaging.c index 755462a..ef54ea1 100644 --- a/drivers/slimbus/messaging.c +++ b/drivers/slimbus/messaging.c @@ -98,7 +98,7 @@ int slim_do_transfer(struct slim_controller *ctrl, struct slim_msg_txn *txn) if (need_tid) { spin_lock_irqsave(&ctrl->txn_lock, flags); tid = idr_alloc(&ctrl->tid_idr, txn, 0, - SLIM_MAX_TIDS, GFP_KERNEL); + SLIM_MAX_TIDS, GFP_ATOMIC); txn->tid = tid; if (!txn->msg->comp)