Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753541AbeABBk2 (ORCPT + 1 other); Mon, 1 Jan 2018 20:40:28 -0500 Received: from szxga05-in.huawei.com ([45.249.212.191]:3249 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753132AbeABBkZ (ORCPT ); Mon, 1 Jan 2018 20:40:25 -0500 From: Wei Yongjun To: Srinivas Kandagatla , Sagar Dharia CC: Wei Yongjun , , Subject: [PATCH -next] slimbus: Fix missing unlock on error in slim_msg_response() Date: Tue, 2 Jan 2018 01:46:00 +0000 Message-ID: <1514857560-83934-1-git-send-email-weiyongjun1@huawei.com> X-Mailer: git-send-email 1.8.3.1 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 X-Originating-IP: [10.175.113.25] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: Add the missing unlock before return from function slim_msg_response() in the error handling case. Fixes: afbdcc7c384b ("slimbus: Add messaging APIs to slimbus framework") Signed-off-by: Wei Yongjun --- drivers/slimbus/messaging.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/slimbus/messaging.c b/drivers/slimbus/messaging.c index 755462a..a1328ac 100644 --- a/drivers/slimbus/messaging.c +++ b/drivers/slimbus/messaging.c @@ -38,6 +38,7 @@ void slim_msg_response(struct slim_controller *ctrl, u8 *reply, u8 tid, u8 len) if (msg == NULL || msg->rbuf == NULL) { dev_err(ctrl->dev, "Got response to invalid TID:%d, len:%d\n", tid, len); + spin_unlock_irqrestore(&ctrl->txn_lock, flags); return; }