Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751744AbeABBya (ORCPT + 1 other); Mon, 1 Jan 2018 20:54:30 -0500 Received: from smtp.csie.ntu.edu.tw ([140.112.30.61]:47016 "EHLO smtp.csie.ntu.edu.tw" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751711AbeABBy3 (ORCPT ); Mon, 1 Jan 2018 20:54:29 -0500 X-Google-Smtp-Source: ACJfBovk/eGfqppoDO5G6U7Ac3rlPzfCbZoHi3U6ep/Me3yhFbsSt4FSQaJiBBY1jPaOJDGmC4SWXYIq7fUcWWmgdlc= MIME-Version: 1.0 In-Reply-To: <20180101192208.11738-1-clabbe.montjoie@gmail.com> References: <20180101192208.11738-1-clabbe.montjoie@gmail.com> From: Chen-Yu Tsai Date: Tue, 2 Jan 2018 09:54:01 +0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] ARM: sunxi_defconfig: Enable SUNXI_CCU To: Corentin Labbe Cc: Russell King , Maxime Ripard , Chen-Yu Tsai , linux-arm-kernel , linux-kernel , linux-sunxi Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On Tue, Jan 2, 2018 at 3:22 AM, Corentin Labbe wrote: > While looking for missing symbol by diffing sunxi_defconfig and my > .config, I just found that no CLK symbol are present in sunxi_defconfig. This does not take into account default values in Kconfig. Use `make savedefconfg` then compare the resulting defconfig file. > > This patch add the missing CONFIG_SUNXI_CCU in sunxi_defconfig. > All other symbol will be automatically selected via their default value. > > Signed-off-by: Corentin Labbe > --- > arch/arm/configs/sunxi_defconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm/configs/sunxi_defconfig b/arch/arm/configs/sunxi_defconfig > index 5caaf971fb50..5ed920e75842 100644 > --- a/arch/arm/configs/sunxi_defconfig > +++ b/arch/arm/configs/sunxi_defconfig > @@ -16,6 +16,7 @@ CONFIG_CPU_FREQ=y > CONFIG_CPUFREQ_DT=y > CONFIG_VFP=y > CONFIG_NEON=y > +CONFIG_SUNXI_CCU=y Not needed. See the last line of: config SUNXI_CCU bool "Clock support for Allwinner SoCs" depends on ARCH_SUNXI || COMPILE_TEST select RESET_CONTROLLER default ARCH_SUNXI Surely kernelci hasn't been broken since the introduction of sunxi-ng. :) ChenYu > CONFIG_NET=y > CONFIG_PACKET=y > CONFIG_UNIX=y > -- > 2.13.6 >