Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751839AbeABFmN (ORCPT + 1 other); Tue, 2 Jan 2018 00:42:13 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:50710 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751216AbeABFmK (ORCPT ); Tue, 2 Jan 2018 00:42:10 -0500 DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 80A3960555 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=mgautam@codeaurora.org Subject: Re: [PATCH v3 14/16] phy: Add notify_speed callback To: Kishon Vijay Abraham I Cc: linux-arm-msm@vger.kernel.org, linux-usb@vger.kernel.org, "open list:GENERIC PHY FRAMEWORK" References: <1511256206-1587-1-git-send-email-mgautam@codeaurora.org> <1511256206-1587-15-git-send-email-mgautam@codeaurora.org> <082d2ca8-21dc-878f-c668-a76872a7ea92@ti.com> <5b67c348-4ec9-58ca-05ed-8b93bed77efb@codeaurora.org> <602bee84-ed3c-4b39-176d-4e6a2f3fbf62@ti.com> From: Manu Gautam Message-ID: Date: Tue, 2 Jan 2018 11:12:06 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 MIME-Version: 1.0 In-Reply-To: <602bee84-ed3c-4b39-176d-4e6a2f3fbf62@ti.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: Hi, On 12/29/2017 11:58 AM, Kishon Vijay Abraham I wrote: > Hi, > > On Friday 29 December 2017 09:54 AM, Manu Gautam wrote: >> Hi, [snip] > > suggest using switch in such case.. and not all PHY drivers do specific > configurations for specific speeds. >> This looks clumsy. >> Where as if bits to used then there is no need for such changes. > really? using bits should only make it more clumsy. Thanks for your feedback. I will update this in next patchset. > -Kishon -- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project