Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751551AbeABHqd (ORCPT + 1 other); Tue, 2 Jan 2018 02:46:33 -0500 Received: from mail-wr0-f195.google.com ([209.85.128.195]:32861 "EHLO mail-wr0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750979AbeABHqc (ORCPT ); Tue, 2 Jan 2018 02:46:32 -0500 X-Google-Smtp-Source: ACJfBosbHErXkLdTrW97hcXJxsG8gWzAPScSIOwqS8t8c0NJGSIZcIUdAG6twSM0TcVh/IT9X3sBOYbRQpgp6PB8I7I= MIME-Version: 1.0 In-Reply-To: <1514866140-108855-1-git-send-email-weiyongjun1@huawei.com> References: <1514866140-108855-1-git-send-email-weiyongjun1@huawei.com> From: Jens Wiklander Date: Tue, 2 Jan 2018 08:46:30 +0100 Message-ID: Subject: Re: [PATCH -next] tee: shm: make local function __tee_shm_alloc() static To: Wei Yongjun Cc: Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On Tue, Jan 2, 2018 at 5:09 AM, Wei Yongjun wrote: > Fixes the following sparse warnings: > > drivers/tee/tee_shm.c:115:16: warning: > symbol '__tee_shm_alloc' was not declared. Should it be static? > > Signed-off-by: Wei Yongjun > --- > drivers/tee/tee_shm.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/tee/tee_shm.c b/drivers/tee/tee_shm.c > index 04e1b8b..13b4de1 100644 > --- a/drivers/tee/tee_shm.c > +++ b/drivers/tee/tee_shm.c > @@ -112,9 +112,9 @@ static int tee_shm_op_mmap(struct dma_buf *dmabuf, struct vm_area_struct *vma) > .mmap = tee_shm_op_mmap, > }; > > -struct tee_shm *__tee_shm_alloc(struct tee_context *ctx, > - struct tee_device *teedev, > - size_t size, u32 flags) > +static struct tee_shm *__tee_shm_alloc(struct tee_context *ctx, > + struct tee_device *teedev, > + size_t size, u32 flags) > { > struct tee_shm_pool_mgr *poolm = NULL; > struct tee_shm *shm; > Thanks, but I've already picked up the same patch from Colin King a few days ago. /Jens