Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751645AbeABJKK (ORCPT <rfc822;ralf@linux-mips.org> + 1 other);
        Tue, 2 Jan 2018 04:10:10 -0500
Received: from mail-it0-f68.google.com ([209.85.214.68]:35387 "EHLO
        mail-it0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1750979AbeABJKI (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 2 Jan 2018 04:10:08 -0500
X-Google-Smtp-Source: ACJfBotIZEyTq8Igh7ivILsaSDnfUbiyL4kjCKtWYdCyWhBuDPl8XIayNjDeeVFAfd6qn+Uw5JPDzpevSGxecxzSnUk=
MIME-Version: 1.0
In-Reply-To: <1514474364-32169-1-git-send-email-mastichi@gmail.com>
References: <1514474364-32169-1-git-send-email-mastichi@gmail.com>
From: Linus Walleij <linus.walleij@linaro.org>
Date: Tue, 2 Jan 2018 10:10:07 +0100
Message-ID: <CACRpkdZp0kp6vTAOj11Tc2mGD4MvWwpMGTQgEhQiQAdUgapcGw@mail.gmail.com>
Subject: Re: [PATCH] pinctrl: mcp23s08: fix irq setup order
To: Dmitry Mastykin <mastichi@gmail.com>,
        Sebastian Reichel <sre@kernel.org>
Cc: Phil Reid <preid@electromag.com.au>, linux-gpio@vger.kernel.org,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>

On Thu, Dec 28, 2017 at 4:19 PM, Dmitry Mastykin <mastichi@gmail.com> wrote:

> When using mcp23s08 module with gpio-keys, often (50% of boots)
> it fails to get irq numbers with message:
> "gpio-keys keys: Unable to get irq number for GPIO 0, error -6".
> Seems that irqs must be setup before devm_gpiochip_add_data().
>
> Signed-off-by: Dmitry Mastykin <mastichi@gmail.com>

Patch applied, albeit for devel.

Should it be tagged for stable or go into fixes?

Yours,
Linus Walleij