Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752359AbeABJgE (ORCPT + 1 other); Tue, 2 Jan 2018 04:36:04 -0500 Received: from mail-qt0-f196.google.com ([209.85.216.196]:45720 "EHLO mail-qt0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751495AbeABJgB (ORCPT ); Tue, 2 Jan 2018 04:36:01 -0500 X-Google-Smtp-Source: ACJfBosgy44p+ls3IefqT0XiWSkwEyaPtnc7qvP4NHAI6sTqS+ISPSISgV6vWph0Rdb20I44UC2HdWWbI6rOpC0TxHY= MIME-Version: 1.0 In-Reply-To: <1514469681-15602-5-git-send-email-jacopo+renesas@jmondi.org> References: <1514469681-15602-1-git-send-email-jacopo+renesas@jmondi.org> <1514469681-15602-5-git-send-email-jacopo+renesas@jmondi.org> From: Geert Uytterhoeven Date: Tue, 2 Jan 2018 10:35:59 +0100 X-Google-Sender-Auth: qK6LPxFucY3AnTsu1XS43gkjkk4 Message-ID: Subject: Re: [PATCH v2 4/9] ARM: dts: r7s72100: Add Capture Engine Unit (CEU) To: Jacopo Mondi Cc: Laurent Pinchart , Magnus Damm , Mauro Carvalho Chehab , Hans Verkuil , Rob Herring , Mark Rutland , Linux-Renesas , Linux Media Mailing List , Linux-sh list , devicetree@vger.kernel.org, Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: Hi Jacopo, On Thu, Dec 28, 2017 at 3:01 PM, Jacopo Mondi wrote: > Add Capture Engine Unit (CEU) node to device tree. Thanks for your patch! > Signed-off-by: Jacopo Mondi With the issue below fixed: Reviewed-by: Geert Uytterhoeven > --- a/arch/arm/boot/dts/r7s72100.dtsi > +++ b/arch/arm/boot/dts/r7s72100.dtsi > @@ -667,4 +667,13 @@ > power-domains = <&cpg_clocks>; > status = "disabled"; > }; > + > + ceu: ceu@e8210000 { > + reg = <0xe8210000 0x209c>; Given the last documented register is at offset 0x209C, the region above is too small (also in the example in the DT bindings). But due to MMU granularity, it will be accessible anyway. reg = <0xe8210000 0x3000>; I assume the mandatory "remote-endpoint" property will come with the board (GR-Peach) DTS patch? Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds