Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751839AbeABKDm (ORCPT + 1 other); Tue, 2 Jan 2018 05:03:42 -0500 Received: from mail-pl0-f67.google.com ([209.85.160.67]:45278 "EHLO mail-pl0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751366AbeABKD0 (ORCPT ); Tue, 2 Jan 2018 05:03:26 -0500 X-Google-Smtp-Source: ACJfBovB7Srz0oIkW/VelSVqjw0ZUUeCi8z8Ecm5y1R7e/Cl18nCfGFiIu6mVevWCEFA6ANN3gC2pQ== From: Joey Pabalinas To: linux-mm@kvack.org Cc: sjenning@redhat.com, ddstreet@ieee.org, linux-kernel@vger.kernel.org, Joey Pabalinas Subject: [PATCH 2/2] mm/zswap: move `zswap_has_pool` to front of `if ()` Date: Tue, 2 Jan 2018 00:03:20 -1000 Message-Id: <20180102100320.24801-3-joeypabalinas@gmail.com> X-Mailer: git-send-email 2.15.1 In-Reply-To: <20180102100320.24801-1-joeypabalinas@gmail.com> References: <20180102100320.24801-1-joeypabalinas@gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: `zwap_has_pool` is a simple boolean, so it should be tested first to avoid unnecessarily calling `strcmp()`. Test `zswap_has_pool` first to take advantage of the short-circuiting behavior of && in `__zswap_param_set()`. Signed-off-by: Joey Pabalinas 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/zswap.c b/mm/zswap.c index a4f2dfaf9131694265..dbf35139471f692798 100644 --- a/mm/zswap.c +++ b/mm/zswap.c @@ -672,7 +672,7 @@ static int __zswap_param_set(const char *val, const struct kernel_param *kp, } /* no change required */ - if (!strcmp(s, *(char **)kp->arg) && zswap_has_pool) + if (zswap_has_pool && !strcmp(s, *(char **)kp->arg)) return 0; /* if this is load-time (pre-init) param setting, -- 2.15.1