Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752040AbeABKRo (ORCPT + 1 other); Tue, 2 Jan 2018 05:17:44 -0500 Received: from mail-pf0-f196.google.com ([209.85.192.196]:47052 "EHLO mail-pf0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751925AbeABKRl (ORCPT ); Tue, 2 Jan 2018 05:17:41 -0500 X-Google-Smtp-Source: ACJfBotuq6HLsAzey+74O3T9sqxdnfH+juUtPhyJlsVCNIoYFgYQsc/XugG0cXt6MQac1iRpOaWJm72ngGWQi7ABwvQ= MIME-Version: 1.0 In-Reply-To: <20171231101508.GB21846@kroah.com> References: <20171227164614.109898944@linuxfoundation.org> <20171229091828.GD18441@kroah.com> <20171231101508.GB21846@kroah.com> From: Milosz Wasilewski Date: Tue, 2 Jan 2018 10:17:40 +0000 Message-ID: Subject: Re: [PATCH 4.14 00/74] 4.14.10-stable review To: Greg Kroah-Hartman Cc: Naresh Kamboju , LKML , Linus Torvalds , Andrew Morton , Guenter Roeck , Shuah Khan , patches@kernelci.org, Ben Hutchings , lkft-triage@lists.linaro.org, linux- stable , Tom Gall Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On 31 December 2017 at 10:15, Greg Kroah-Hartman wrote: >> >> I re-tested ldt_gdt_64 again locally and in testing LAB. The test >> failed again so I think this is a regression. I did the bisection >> which resulted in >> >> 2c8e9099aecec2baaac8d34c7b823493f2d0eeed is the first bad commit >> commit 2c8e9099aecec2baaac8d34c7b823493f2d0eeed >> Author: Thomas Gleixner >> Date: Thu Dec 14 12:27:31 2017 +0100 >> >> x86/ldt: Prevent LDT inheritance on exec >> >> commit a4828f81037f491b2cc986595e3a969a6eeb2fb5 upstream. >> >> Reverting this commit makes he ldt_gdt_64 pass again. However it's >> worth to mention that the test uses a pre-build version of kselftest >> from 4.14 (sources here: >> https://www.kernel.org/pub/linux/kernel/v4.x/linux-4.14.tar.xz). The >> offending commit also changed tools/testing/selftests/x86/ldt_gdt.c. I >> re-tested original build using this version of kselftests and the >> ldt_gdt_64 passes (as expected). This makes me thinking whether using >> the 'old' version of kselftests is a good idea. > > You should use the version with the fix, for the obvious reason as > documented in the selftest change :) I'll move all our stable builds to use kselftests from 4.14.10. milosz