Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752450AbeABK3Q (ORCPT + 1 other); Tue, 2 Jan 2018 05:29:16 -0500 Received: from mail-qk0-f194.google.com ([209.85.220.194]:39072 "EHLO mail-qk0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751872AbeABK3M (ORCPT ); Tue, 2 Jan 2018 05:29:12 -0500 X-Google-Smtp-Source: ACJfBosNH1RDBVToRHUH8e3Jz325i8NnKH7E7ZaJYGNEvf5hnfEy3bdaJSSG1FmoX13TBB8Z9UZ2JFfdImq3g15LkT0= MIME-Version: 1.0 In-Reply-To: <20171229081911.2802-30-hch@lst.de> References: <20171229081911.2802-1-hch@lst.de> <20171229081911.2802-30-hch@lst.de> From: Geert Uytterhoeven Date: Tue, 2 Jan 2018 11:29:10 +0100 X-Google-Sender-Auth: drZoEJHFwEyPr2WG9pptpvwNdUw Message-ID: Subject: Re: [PATCH 29/67] dma-direct: use node local allocations for coherent memory To: Christoph Hellwig Cc: iommu@lists.linux-foundation.org, alpha , arcml , linux-arm-kernel@lists.infradead.org, adi-buildroot-devel@lists.sourceforge.net, linux-c6x-dev@linux-c6x.org, Cris , "open list:QUALCOMM HEXAGON..." , linux-ia64@vger.kernel.org, linux-m68k , "open list:METAG ARCHITECTURE" , Michal Simek , Linux MIPS Mailing List , Parisc List , linuxppc-dev@lists.ozlabs.org, patches@groups.riscv.org, linux-s390 , Linux-sh list , sparclinux , Guan Xuetao , "the arch/x86 maintainers" , Linux-Arch , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: Missing patch description explaining why this change is desirable. On Fri, Dec 29, 2017 at 9:18 AM, Christoph Hellwig wrote: > --- a/lib/dma-direct.c > +++ b/lib/dma-direct.c > @@ -39,7 +39,7 @@ static void *dma_direct_alloc(struct device *dev, size_t size, > if (gfpflags_allow_blocking(gfp)) > page = dma_alloc_from_contiguous(dev, count, page_order, gfp); > if (!page) > - page = alloc_pages(gfp, page_order); > + page = alloc_pages_node(dev_to_node(dev), gfp, page_order); > if (!page) > return NULL; > Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds