Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752127AbeABMCP (ORCPT + 1 other); Tue, 2 Jan 2018 07:02:15 -0500 Received: from mail-wm0-f68.google.com ([74.125.82.68]:38494 "EHLO mail-wm0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751915AbeABMCN (ORCPT ); Tue, 2 Jan 2018 07:02:13 -0500 X-Google-Smtp-Source: ACJfBou/zT8gPCRIYqeRy7a4vCNXWuKIxLgYsCd8Atc7XJFpfnWVKeOy0BopdJxAPc4yXH1N4LXnmg== Subject: Re: [PATCH v2 1/2] nvmem: add driver for JZ4780 efuse To: Mathieu Malaterre , Marcin Nowakowski Cc: Greg Kroah-Hartman , Zubair.Kakakhel@mips.com, PrasannaKumar Muralidharan , Rob Herring , Mark Rutland , Ralf Baechle , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-mips@linux-mips.org References: <20171228212954.2922-1-malat@debian.org> <20171228212954.2922-2-malat@debian.org> From: Srinivas Kandagatla Message-ID: <3ec9ddab-f855-8c39-4d75-d35be7bd6731@linaro.org> Date: Tue, 2 Jan 2018 12:02:10 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <20171228212954.2922-2-malat@debian.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On 28/12/17 21:29, Mathieu Malaterre wrote: > From: PrasannaKumar Muralidharan > > This patch brings support for the JZ4780 efuse. Currently it only expose > a read only access to the entire 8K bits efuse memory. > > Tested-by: Mathieu Malaterre > Signed-off-by: PrasannaKumar Muralidharan > Signed-off-by: Mathieu Malaterre > --- Please split this patch, as you are mixing code, documentation, dts and MAINTAINER changes here. Without which patch can not be reviewed!! Thanks, Srini > .../ABI/testing/sysfs-driver-jz4780-efuse | 16 ++ > .../bindings/nvmem/ingenic,jz4780-efuse.txt | 17 ++ > MAINTAINERS | 5 + > arch/mips/boot/dts/ingenic/jz4780.dtsi | 40 ++- > drivers/nvmem/Kconfig | 10 + > drivers/nvmem/Makefile | 2 + > drivers/nvmem/jz4780-efuse.c | 305 +++++++++++++++++++++ > 7 files changed, 383 insertions(+), 12 deletions(-) ...