Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752744AbeABMf5 (ORCPT + 1 other); Tue, 2 Jan 2018 07:35:57 -0500 Received: from mail-pf0-f195.google.com ([209.85.192.195]:45601 "EHLO mail-pf0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751685AbeABMf4 (ORCPT ); Tue, 2 Jan 2018 07:35:56 -0500 X-Google-Smtp-Source: ACJfBot+Y5cbb2mA+o1EZ9XWIluoyw4tjZbsaRd9pymCGoD3V4hers0ddd5CFlDK0YjGP5WsupitzQ== From: Xiongwei Song To: christian.koenig@amd.com, Hongbo.He@amd.com, airlied@linux.ie Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: [PATCH v2] drm/ttm: check the return value of kzalloc Date: Tue, 2 Jan 2018 20:35:26 +0800 Message-Id: <20180102123526.21057-1-sxwjean@gmail.com> X-Mailer: git-send-email 2.15.1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: In the function ttm_page_alloc_init, kzalloc call is made for variable _manager, we need to check its return value, it may return NULL. Signed-off-by: Xiongwei Song --- v1->v2: delete kfree _manager --- drivers/gpu/drm/ttm/ttm_page_alloc.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/gpu/drm/ttm/ttm_page_alloc.c b/drivers/gpu/drm/ttm/ttm_page_alloc.c index b5ba6441489f..583d73edb7df 100644 --- a/drivers/gpu/drm/ttm/ttm_page_alloc.c +++ b/drivers/gpu/drm/ttm/ttm_page_alloc.c @@ -1007,6 +1007,10 @@ int ttm_page_alloc_init(struct ttm_mem_global *glob, unsigned max_pages) pr_info("Initializing pool allocator\n"); _manager = kzalloc(sizeof(*_manager), GFP_KERNEL); + if (!_manager) { + ret = -ENOMEM; + goto out; + } ttm_page_pool_init_locked(&_manager->wc_pool, GFP_HIGHUSER, "wc", 0); @@ -1041,6 +1045,8 @@ int ttm_page_alloc_init(struct ttm_mem_global *glob, unsigned max_pages) ttm_pool_mm_shrink_init(_manager); return 0; +out: + return ret; } void ttm_page_alloc_fini(void) -- 2.15.1