Subject: Re: [PATCH 0/4] KVM: nVMX: prepare_vmcs02 optimizations
To: Wanpeng Li <kernellwp@gmail.com>
Cc: linux-kernel@vger.kernel.org, kvm <kvm@vger.kernel.org>
References: <1513860222-40944-1-git-send-email-pbonzini@redhat.com>
 <CANRm+Cy+Jy=oX3+-sggnhg90ZS-15WsJftgKy=9YARM2oUpWnA@mail.gmail.com>
 <CANRm+CxN8F_Wvb3w6e0rxXz6AwsnhE_Ugf5coJAMvqrGz0H+-A@mail.gmail.com>
 <d4122b14-710f-5b50-c4f2-095901756e19@redhat.com>
 <CANRm+CyNB9=X9wpACG4KtUiO1Mp-0JUWuXvbkXPEN7V69hjrEA@mail.gmail.com>
 <dfd3b350-dd7d-7031-e1d5-d930ea917fa7@redhat.com>
 <cb657fb9-62f5-b241-7cf9-5a422fe34995@redhat.com>
 <CANRm+Cx5E3-v684BU2Opmi8GRPVqsend1WMxDKUR2qO_4XoRLg@mail.gmail.com>
From: Paolo Bonzini <pbonzini@redhat.com>
Message-ID: <8a500669-8529-de09-343c-fd54172a588f@redhat.com>
Date: Tue, 2 Jan 2018 14:02:23 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.5.0
MIME-Version: 1.0
In-Reply-To: <CANRm+Cx5E3-v684BU2Opmi8GRPVqsend1WMxDKUR2qO_4XoRLg@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org

On 02/01/2018 02:05, Wanpeng Li wrote:
> The issue is still there after applying this to both L0 and L1,
> actually, I can observe a vmentry fail just before the splatting in L0
> w/ and w/o the above code. In addition, I comment out the other
> testcases in unittests.cfg except vmx_controls, then run
> ./run_tests.sh.

Ok, I didn't understand that you're running vmx.flat inside L1 (thus
creating an L3 guest).  The patch I sent is wrong, because
SECONDARY_EXEC_DESC should always be clear in vmx->secondary_exec_control.

Note that even with "-cpu host,+vmx,-umip" I get a hang at

	PASS: Use TPR shadow enabled: TPR threshold 0x10: vmlaunch fails

So that might not be entirely related.  However, the failures with
descriptor exiting are new.

Paolo