Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752476AbeABOJB (ORCPT + 1 other); Tue, 2 Jan 2018 09:09:01 -0500 Received: from vps0.lunn.ch ([185.16.172.187]:50394 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752040AbeABOI7 (ORCPT ); Tue, 2 Jan 2018 09:08:59 -0500 Date: Tue, 2 Jan 2018 15:08:52 +0100 From: Andrew Lunn To: Marcin Wojtas Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, netdev , linux-acpi@vger.kernel.org, Graeme Gregory , "David S. Miller" , Russell King - ARM Linux , "Rafael J. Wysocki" , Florian Fainelli , Antoine =?iso-8859-1?Q?T=E9nart?= , Thomas Petazzoni , Gregory =?iso-8859-1?Q?Cl=E9ment?= , Ezequiel Garcia , nadavh@marvell.com, Neta Zur Hershkovits , Ard Biesheuvel , Grzegorz Jaszczyk , Tomasz Nowicki Subject: Re: [net-next: PATCH v2 5/5] net: mvpp2: enable ACPI support in the driver Message-ID: <20180102140852.GE15036@lunn.ch> References: <1514721520-18964-1-git-send-email-mw@semihalf.com> <1514721520-18964-6-git-send-email-mw@semihalf.com> <20171231192354.GB20455@lunn.ch> <20180102133347.GB15036@lunn.ch> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: > Indeed in of_mdio_bus_register_phy, there is of_irq_get. This is more > a discussion for a MDIO bus / ACPI patchset, but we either find a way > to use IRQs with ACPI obtained from child nodes or for this world the > functionality will be limited (at least for the beginning). Hi Marcin What i want to avoid is adding something which partially works, and then have to throw it all away and start again in order to add full support. If ACPI really limits interrupts to devices, maybe we need a totally different representation of MDIO and PHYs in ACPI to what it used in device tree? The same may be true for the Ethernet ports of the mvpp2? They might have to be represented as real devices, not children of a device? Maybe trying to map DT to ACPI on a one-to-one basis is the wrong approach? Andrew