Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752808AbeABOPe (ORCPT + 1 other); Tue, 2 Jan 2018 09:15:34 -0500 Received: from userp2130.oracle.com ([156.151.31.86]:54825 "EHLO userp2130.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751447AbeABOPd (ORCPT ); Tue, 2 Jan 2018 09:15:33 -0500 Subject: Re: [PATCH] x86/xen/time: fix section mismatch for xen_init_time_ops() To: Nick Desaulniers Cc: Juergen Gross , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , x86@kernel.org, xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org References: <1514083813-27047-1-git-send-email-nick.desaulniers@gmail.com> From: Boris Ostrovsky Message-ID: <52b547c5-509a-3a82-12cd-4d9d0a06b53f@oracle.com> Date: Tue, 2 Jan 2018 09:18:33 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <1514083813-27047-1-git-send-email-nick.desaulniers@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-US X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=8761 signatures=668650 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=913 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1711220000 definitions=main-1801020210 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On 12/23/2017 09:50 PM, Nick Desaulniers wrote: > The header declares this function as __init but is defined in __ref > section. > > Signed-off-by: Nick Desaulniers AFAIK section attributes in header files are ignored by compiler anyway so I'd remove all of them. -boris > --- > arch/x86/xen/xen-ops.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/x86/xen/xen-ops.h b/arch/x86/xen/xen-ops.h > index 75011b8..3b34745 100644 > --- a/arch/x86/xen/xen-ops.h > +++ b/arch/x86/xen/xen-ops.h > @@ -72,7 +72,7 @@ u64 xen_clocksource_read(void); > void xen_setup_cpu_clockevents(void); > void xen_save_time_memory_area(void); > void xen_restore_time_memory_area(void); > -void __init xen_init_time_ops(void); > +void __ref xen_init_time_ops(void); > void __init xen_hvm_init_time_ops(void); > > irqreturn_t xen_debug_interrupt(int irq, void *dev_id);