Subject: Re: [PATCH v3] drm/ttm: check the return value of kzalloc
To: Xiongwei Song <sxwjean@gmail.com>, Hongbo.He@amd.com,
        airlied@linux.ie
Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
References: <20180102132455.5413-1-sxwjean@gmail.com>
From: =?UTF-8?Q?Christian_K=c3=b6nig?= <christian.koenig@amd.com>
Message-ID: <89ed14e3-a570-4b4c-07d5-81cf5040e8d6@amd.com>
Date: Tue, 2 Jan 2018 15:33:51 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.5.0
MIME-Version: 1.0
In-Reply-To: <20180102132455.5413-1-sxwjean@gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-US
SpamDiagnosticOutput: 1:99
SpamDiagnosticMetadata: NSPM
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Jan 2018 14:34:02.2404 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: d8191bc7-ed95-4072-869b-08d551eddf48
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR12MB1304
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>

Am 02.01.2018 um 14:24 schrieb Xiongwei Song:
> In the function ttm_page_alloc_init, kzalloc call is made for variable
> _manager, we need to check its return value, it may return NULL.
>
> Signed-off-by: Xiongwei Song <sxwjean@gmail.com>

Reviewed-by: Christian König <christian.koenig@amd.com>

Going to pick that up for the next release.

Thanks,
Christian.

> ---
> v2->v3: delete goto expression
> v1->v2: delete kfree _manager
> ---
>   drivers/gpu/drm/ttm/ttm_page_alloc.c | 2 ++
>   1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/ttm/ttm_page_alloc.c b/drivers/gpu/drm/ttm/ttm_page_alloc.c
> index b5ba6441489f..5d252fb27a82 100644
> --- a/drivers/gpu/drm/ttm/ttm_page_alloc.c
> +++ b/drivers/gpu/drm/ttm/ttm_page_alloc.c
> @@ -1007,6 +1007,8 @@ int ttm_page_alloc_init(struct ttm_mem_global *glob, unsigned max_pages)
>   	pr_info("Initializing pool allocator\n");
>   
>   	_manager = kzalloc(sizeof(*_manager), GFP_KERNEL);
> +	if (!_manager)
> +		return -ENOMEM;
>   
>   	ttm_page_pool_init_locked(&_manager->wc_pool, GFP_HIGHUSER, "wc", 0);
>