Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751228AbeABQRz (ORCPT <rfc822;ralf@linux-mips.org> + 1 other);
        Tue, 2 Jan 2018 11:17:55 -0500
Received: from mail-it0-f68.google.com ([209.85.214.68]:36972 "EHLO
        mail-it0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751022AbeABQRy (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 2 Jan 2018 11:17:54 -0500
X-Google-Smtp-Source: ACJfBovQv8P9l3WoIqlZPK7uVoJ0RCLsxYW0Q5bS+7s8R76ZEBt1IdIuTcHudtXxrE2kS3qEVQNMogNEYf9qeoUMoxQ=
MIME-Version: 1.0
In-Reply-To: <3ec9ddab-f855-8c39-4d75-d35be7bd6731@linaro.org>
References: <20171228212954.2922-1-malat@debian.org> <20171228212954.2922-2-malat@debian.org>
 <3ec9ddab-f855-8c39-4d75-d35be7bd6731@linaro.org>
From: PrasannaKumar Muralidharan <prasannatsmkumar@gmail.com>
Date: Tue, 2 Jan 2018 21:47:53 +0530
Message-ID: <CANc+2y7_Bx7APkD2pDEQUT9cJqXEUCPkDQuzO_GP1qENabnNeQ@mail.gmail.com>
Subject: Re: [PATCH v2 1/2] nvmem: add driver for JZ4780 efuse
To: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Cc: Mathieu Malaterre <malat@debian.org>,
        Marcin Nowakowski <marcin.nowakowski@mips.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Zubair.Kakakhel@mips.com, Rob Herring <robh+dt@kernel.org>,
        Mark Rutland <mark.rutland@arm.com>,
        Ralf Baechle <ralf@linux-mips.org>,
        open list <linux-kernel@vger.kernel.org>,
        devicetree@vger.kernel.org, linux-mips@linux-mips.org
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>

Hi Srini,

On 2 January 2018 at 17:32, Srinivas Kandagatla
<srinivas.kandagatla@linaro.org> wrote:
>
>
> On 28/12/17 21:29, Mathieu Malaterre wrote:
>>
>> From: PrasannaKumar Muralidharan <prasannatsmkumar@gmail.com>
>>
>> This patch brings support for the JZ4780 efuse. Currently it only expose
>> a read only access to the entire 8K bits efuse memory.
>>
>> Tested-by: Mathieu Malaterre <malat@debian.org>
>> Signed-off-by: PrasannaKumar Muralidharan <prasannatsmkumar@gmail.com>
>> Signed-off-by: Mathieu Malaterre <malat@debian.org>
>> ---
>
> Please split this patch, as you are mixing code, documentation, dts and
> MAINTAINER changes here.
>
> Without which patch can not be reviewed!!

Sure, will do it soon.

>
> Thanks,
> Srini
>
>>   .../ABI/testing/sysfs-driver-jz4780-efuse          |  16 ++
>
>
>>   .../bindings/nvmem/ingenic,jz4780-efuse.txt        |  17 ++
>>   MAINTAINERS                                        |   5 +
>>   arch/mips/boot/dts/ingenic/jz4780.dtsi             |  40 ++-
>>   drivers/nvmem/Kconfig                              |  10 +
>>   drivers/nvmem/Makefile                             |   2 +
>>   drivers/nvmem/jz4780-efuse.c                       | 305
>> +++++++++++++++++++++
>>   7 files changed, 383 insertions(+), 12 deletions(-)
>
> ...

Regards,
PrasannaKumar