Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751391AbeABR1w (ORCPT + 1 other); Tue, 2 Jan 2018 12:27:52 -0500 Received: from merlin.infradead.org ([205.233.59.134]:52892 "EHLO merlin.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751288AbeABR1t (ORCPT ); Tue, 2 Jan 2018 12:27:49 -0500 Subject: Re: [PATCH] netfilter: add nf_queue_entry forward declaration To: Arnd Bergmann , Pablo Neira Ayuso , Jozsef Kadlecsik , Florian Westphal Cc: netfilter-devel@vger.kernel.org, coreteam@netfilter.org, linux-kernel@vger.kernel.org References: <20180102101644.200962-1-arnd@arndb.de> From: Randy Dunlap Message-ID: <92911fb4-570f-4dd1-739d-9d20d2a37f30@infradead.org> Date: Tue, 2 Jan 2018 09:27:41 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 MIME-Version: 1.0 In-Reply-To: <20180102101644.200962-1-arnd@arndb.de> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On 01/02/2018 02:16 AM, Arnd Bergmann wrote: > The newly added callback pointers cause a warning for some configurations: > > In file included from net/ipv6/af_inet6.c:45:0: > include/linux/netfilter_ipv6.h:38:51: error: 'struct nf_queue_entry' declared inside parameter list will not be visible outside of this definition or declaration [-Werror] > > Adding a forward declaration for the type avoids the warnings. > > Fixes: 9faa679ee7ec ("netfilter: move reroute indirection to struct nf_ipv6_ops") > Signed-off-by: Arnd Bergmann Acked-and-tested-by: Randy Dunlap Thanks. > --- > include/linux/netfilter_ipv4.h | 2 ++ > include/linux/netfilter_ipv6.h | 2 ++ > 2 files changed, 4 insertions(+) > > diff --git a/include/linux/netfilter_ipv4.h b/include/linux/netfilter_ipv4.h > index 0259bcde6d2e..b31dabfdb453 100644 > --- a/include/linux/netfilter_ipv4.h > +++ b/include/linux/netfilter_ipv4.h > @@ -18,6 +18,8 @@ struct ip_rt_info { > > int ip_route_me_harder(struct net *net, struct sk_buff *skb, unsigned addr_type); > > +struct nf_queue_entry; > + > #ifdef CONFIG_INET > __sum16 nf_ip_checksum(struct sk_buff *skb, unsigned int hook, > unsigned int dataoff, u_int8_t protocol); > diff --git a/include/linux/netfilter_ipv6.h b/include/linux/netfilter_ipv6.h > index e4cdcfdce0f9..288c597e75b3 100644 > --- a/include/linux/netfilter_ipv6.h > +++ b/include/linux/netfilter_ipv6.h > @@ -18,6 +18,8 @@ struct ip6_rt_info { > u_int32_t mark; > }; > > +struct nf_queue_entry; > + > /* > * Hook functions for ipv6 to allow xt_* modules to be built-in even > * if IPv6 is a module. > -- ~Randy