Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751283AbeABRaK (ORCPT + 1 other); Tue, 2 Jan 2018 12:30:10 -0500 Received: from shards.monkeyblade.net ([184.105.139.130]:50020 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750968AbeABRaJ (ORCPT ); Tue, 2 Jan 2018 12:30:09 -0500 Date: Tue, 02 Jan 2018 12:27:53 -0500 (EST) Message-Id: <20180102.122753.680821948903803520.davem@davemloft.net> To: baijiaju1990@gmail.com Cc: mlindner@marvell.com, stephen@networkplumber.org, shemminger@linux-foundation.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] sky2: Replace mdelay with msleep in sky2_vpd_wait From: David Miller In-Reply-To: <1514632187-14849-1-git-send-email-baijiaju1990@gmail.com> References: <1514632187-14849-1-git-send-email-baijiaju1990@gmail.com> X-Mailer: Mew version 6.7 on Emacs 25.3 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 02 Jan 2018 09:30:08 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: From: Jia-Ju Bai Date: Sat, 30 Dec 2017 19:09:47 +0800 > sky2_vpd_wait is not called in an interrupt handler nor holding a spinlock. > The function mdelay in it can be replaced with msleep, to reduce busy wait. > > Signed-off-by: Jia-Ju Bai Applied.