Date: Tue, 02 Jan 2018 13:32:00 -0500 (EST)
Message-Id: <20180102.133200.293358868256951664.davem@davemloft.net>
To: ncardwell@google.com
Cc: gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
        torvalds@linux-foundation.org, akpm@linux-foundation.org,
        linux@roeck-us.net, shuahkh@osg.samsung.com, patches@kernelci.org,
        ben.hutchings@codethink.co.uk, lkft-triage@lists.linaro.org,
        stable@vger.kernel.org, ycheng@google.com, soheil@google.com,
        edumazet@google.com
Subject: Re: [PATCH 4.9 00/75] 4.9.74-stable review
From: David Miller <davem@davemloft.net>
In-Reply-To: <CADVnQy=HOCkOKNLAvDv9BL6zRF7sjnrFBE9Qy+rivkzRwTPc=Q@mail.gmail.com>
References: <20180101140056.475827799@linuxfoundation.org>
        <CADVnQy=HOCkOKNLAvDv9BL6zRF7sjnrFBE9Qy+rivkzRwTPc=Q@mail.gmail.com>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org

From: Neal Cardwell <ncardwell@google.com>
Date: Tue, 2 Jan 2018 11:57:59 -0500

> On Mon, Jan 1, 2018 at 9:31 AM, Greg Kroah-Hartman
> <gregkh@linuxfoundation.org> wrote:
>> This is the start of the stable review cycle for the 4.9.74 release.
>> There are 75 patches in this series, all will be posted as a response
>> to this one.  If anyone has any issues with these being applied, please
>> let me know.
>>
>> Responses should be made by Wed Jan  3 14:00:03 UTC 2018.
>> Anything received after that time might be too late.
>>
>> The whole patch series can be found in one patch at:
>>         kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.9.74-rc1.gz
>> or in the git tree and branch at:
>>   git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.9.y
>> and the diffstat can be found below.
> 
> Hi Greg,
> 
> In looking at the 4.9 and 4.14 patches yesterday, I noticed there were
> two TCP BBR fixes that made it into 4.14 but not 4.9. Doing an
> inventory of the TCP BBR fixes, AFAICT we have:
> 
> c589e69b508d tcp_bbr: record "full bw reached" decision in new
> full_bw_reached bit
>  - in 4.9 and 4.14 (great)
> 
> 2f6c498e4f15 tcp_bbr: reset full pipe detection on loss recovery undo
>   - in 4.14 (but not 4.9)
> 
> 600647d467c6 tcp_bbr: reset long-term bandwidth sampling on loss recovery undo
>   - in 4.14 (but not 4.9)
> 
> Lacking the second and third patches in 4.9 will not cause any new
> problems, but it will miss out on some nice fixes. If it's possible to
> get  2f6c498e4f15 and 600647d467c6 either into 4.9.74 or 4.9.75, I
> would be very grateful.

These were not straight-forward to backport and I felt the risk outweighed
the gains.

If you want to do the backport yourself and you feel confident in it,
feel free.