Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751492AbeABSx0 (ORCPT + 1 other); Tue, 2 Jan 2018 13:53:26 -0500 Received: from mail-wr0-f195.google.com ([209.85.128.195]:39026 "EHLO mail-wr0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751001AbeABSxZ (ORCPT ); Tue, 2 Jan 2018 13:53:25 -0500 X-Google-Smtp-Source: ACJfBotR+lWVXX0PcIxW6Vkt17e8IC6218vEq9HRqEVQ5pbysC/curYKSIsfdnqDSg+Zy1ooJ/s8/g== From: Mathieu Malaterre To: James Hogan Cc: Mathieu Malaterre , Ralf Baechle , linux-mips@linux-mips.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 2/2] MIPS: Remove a warning when PHYS_OFFSET is 0x0 Date: Tue, 2 Jan 2018 19:53:15 +0100 Message-Id: <20180102185316.9190-1-malat@debian.org> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20171226113717.15074-2-malat@debian.org> References: <20171226113717.15074-2-malat@debian.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: Rewrite the comparison in `else if` statement, case where `min_low_pfn > ARCH_PFN_OFFSET` has already been checked in the first `if` statement: if (min_low_pfn > ARCH_PFN_OFFSET) { Fix non-fatal warning during compilation using W=1: arch/mips/kernel/setup.c: In function ‘bootmem_init’: arch/mips/kernel/setup.c:461:25: warning: comparison of unsigned expression < 0 is always false [-Wtype-limits] } else if (min_low_pfn < ARCH_PFN_OFFSET) { ^ Reviewed-by: James Hogan Signed-off-by: Mathieu Malaterre --- v2: clarify W=1 in commit message arch/mips/kernel/setup.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/mips/kernel/setup.c b/arch/mips/kernel/setup.c index 68db4bdd3255..791dc78b132b 100644 --- a/arch/mips/kernel/setup.c +++ b/arch/mips/kernel/setup.c @@ -459,7 +459,7 @@ static void __init bootmem_init(void) pr_info("Wasting %lu bytes for tracking %lu unused pages\n", (min_low_pfn - ARCH_PFN_OFFSET) * sizeof(struct page), min_low_pfn - ARCH_PFN_OFFSET); - } else if (min_low_pfn < ARCH_PFN_OFFSET) { + } else if (ARCH_PFN_OFFSET - min_low_pfn > 0UL) { pr_info("%lu free pages won't be used\n", ARCH_PFN_OFFSET - min_low_pfn); } -- 2.11.0