Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751463AbeABTJS (ORCPT + 1 other); Tue, 2 Jan 2018 14:09:18 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:35584 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750837AbeABTJQ (ORCPT ); Tue, 2 Jan 2018 14:09:16 -0500 DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 77D1A60285 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=okaya@codeaurora.org Subject: Re: [PATCH v2 0/4] Address error and recovery for AER and DPC To: Bjorn Helgaas , Oza Pawandeep Cc: Bjorn Helgaas , Philippe Ombredanne , Thomas Gleixner , Greg Kroah-Hartman , Kate Stewart , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, Dongdong Liu , Gabriele Paoloni , Keith Busch , Wei Zhang , Timur Tabi References: <1514532259-19383-1-git-send-email-poza@codeaurora.org> <20180102190215.GC6211@bhelgaas-glaptop.roam.corp.google.com> From: Sinan Kaya Message-ID: <3b819352-3efc-002c-897b-2d8536c92d94@codeaurora.org> Date: Tue, 2 Jan 2018 14:09:13 -0500 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <20180102190215.GC6211@bhelgaas-glaptop.roam.corp.google.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On 1/2/2018 2:02 PM, Bjorn Helgaas wrote: > I read that as suggesting that we should enable DPC support in Linux > if and only if we also enable AER. But I don't see anything in DPC > that looks like that. Should there be something there? Should DPC be > restructured so it's enabled and handled inside the AER driver instead > of being a separate driver? I think Keith posted a patch to do this. If firmware first is enabled, DPC init is skipped after his patch. Oza was able to plumb the DPC handling into error recovery callbacks of the portdrv since the portdrv layer already provides this facilities such as reset_link and resume. The way DPC and AER works is almost identical from AER portdrv perspective. I really like his plumbing. Putting DPC code into AER makes it more convoluted in my opinion. -- Sinan Kaya Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc. Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.