Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751432AbeABUAz (ORCPT + 1 other); Tue, 2 Jan 2018 15:00:55 -0500 Received: from mga01.intel.com ([192.55.52.88]:33472 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751014AbeABUAy (ORCPT ); Tue, 2 Jan 2018 15:00:54 -0500 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.45,498,1508828400"; d="scan'208";a="16285371" Subject: Re: [alsa-devel] [PATCH -next] soundwire: Fix typo in return value check of sdw_read() To: Wei Yongjun , Vinod Koul , Sanyog Kale Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org References: <1514866099-108711-1-git-send-email-weiyongjun1@huawei.com> From: Pierre-Louis Bossart Message-ID: Date: Tue, 2 Jan 2018 14:00:52 -0600 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <1514866099-108711-1-git-send-email-weiyongjun1@huawei.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On 1/1/18 10:08 PM, Wei Yongjun wrote: > Fix the typo, 'status' should be instead of 'status2'. well spotted, thanks! Acked-by: Pierre-Louis Bossart > > Fixes: b0a9c37b0178 ("soundwire: Add slave status handling") > Signed-off-by: Wei Yongjun > --- > drivers/soundwire/bus.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/drivers/soundwire/bus.c b/drivers/soundwire/bus.c > index 4c34519..266d2b3 100644 > --- a/drivers/soundwire/bus.c > +++ b/drivers/soundwire/bus.c > @@ -671,8 +671,8 @@ static int sdw_handle_dp0_interrupt(struct sdw_slave *slave, u8 *slave_status) > status2 = sdw_read(slave, SDW_DP0_INT); > if (status2 < 0) { > dev_err(slave->bus->dev, > - "SDW_DP0_INT read failed:%d", status); > - return status; > + "SDW_DP0_INT read failed:%d", status2); > + return status2; > } > status &= status2; > > @@ -741,10 +741,10 @@ static int sdw_handle_port_interrupt(struct sdw_slave *slave, > > /* Read DPN interrupt again */ > status2 = sdw_read(slave, addr); > - if (status < 0) { > + if (status2 < 0) { > dev_err(slave->bus->dev, > - "SDW_DPN_INT read failed:%d", status); > - return status; > + "SDW_DPN_INT read failed:%d", status2); > + return status2; > } > status &= status2; > > _______________________________________________ > Alsa-devel mailing list > Alsa-devel@alsa-project.org > http://mailman.alsa-project.org/mailman/listinfo/alsa-devel >