Date: Tue, 2 Jan 2018 12:24:54 -0800
From: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
To: Rao Shoaib <rao.shoaib@oracle.com>
Cc: Matthew Wilcox <willy@infradead.org>, linux-kernel@vger.kernel.org,
        brouer@redhat.com, linux-mm@kvack.org
Subject: Re: [PATCH] Move kfree_call_rcu() to slab_common.c
Reply-To: paulmck@linux.vnet.ibm.com
References: <1513844387-2668-1-git-send-email-rao.shoaib@oracle.com>
 <20171221123630.GB22405@bombadil.infradead.org>
 <44044955-1ef9-1d1e-5311-d8edc006b812@oracle.com>
 <20171222013937.GA7829@linux.vnet.ibm.com>
 <106f9cdb-bb0b-539d-547e-18c509ca1163@oracle.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <106f9cdb-bb0b-539d-547e-18c509ca1163@oracle.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Message-Id: <20180102202454.GQ7829@linux.vnet.ibm.com>
Sender: linux-kernel-owner@vger.kernel.org

On Thu, Dec 21, 2017 at 07:17:35PM -0800, Rao Shoaib wrote:
> 
> 
> On 12/21/2017 05:39 PM, Paul E. McKenney wrote:
> >>I left it out on purpose because the call in tiny is a little different
> >>
> >>rcutiny.h:
> >>
> >>static inline void kfree_call_rcu(struct rcu_head *head,
> >> ??? ??? ??? ??? ? void (*func)(struct rcu_head *rcu))
> >>{
> >> ??? call_rcu(head, func);
> >>}
> >>
> >>tree.c:
> >>
> >>void kfree_call_rcu(struct rcu_head *head,
> >> ??? ??? ??? void (*func)(struct rcu_head *rcu))
> >>{
> >> ??? __call_rcu(head, func, rcu_state_p, -1, 1);
> >>}
> >>EXPORT_SYMBOL_GPL(kfree_call_rcu);
> >>
> >>If we want the code to be exactly same I can create a lazy version
> >>for tiny as well. However,? I don not know where to move
> >>kfree_call_rcu() from it's current home in rcutiny.h though. Any
> >>thoughts ?
> >I might be missing something subtle here, but in case I am not, my
> >suggestion is to simply rename rcutiny.h's kfree_call_rcu() and otherwise
> >leave it as is.  If you want to update the type of the second argument,
> >which got missed back in the day, there is always this:
> >
> >static inline void call_rcu_lazy(struct rcu_head *head, rcu_callback_t func)
> >{
> >	call_rcu(head, func);
> >}
> >
> >The reason that Tiny RCU doesn't handle laziness specially is because
> >Tree RCU's handling of laziness is a big no-op on the single CPU systems
> >on which Tiny RCU runs.  So Tiny RCU need do nothing special to support
> >laziness.
> >
> >							Thanx, Paul
> >
> Hi Paul,
> 
> I can not just change the name as __kfree_call_rcu macro calls
> kfree_call_rcu(). I have made tiny version of kfree_call_rcu() call
> rcu_call_lazy() which calls call_rcu(). As far as the type is
> concerned, my bad, I cut and posted from an older release. Latest
> code is already using the typedef.

Hello, Rao,

Perhaps it would be best if you simply reposted the latest patch.  ;-)

							Thanx, Paul