Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751514AbeACGci (ORCPT + 1 other); Wed, 3 Jan 2018 01:32:38 -0500 Received: from mail-oi0-f65.google.com ([209.85.218.65]:34425 "EHLO mail-oi0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751148AbeACGcg (ORCPT ); Wed, 3 Jan 2018 01:32:36 -0500 X-Google-Smtp-Source: ACJfBouZ1xZWuHgzf7jfqJanMAzRfTd0pdow2LbPQjoWZHi/3CI0cK4tWdN+tazXBxnKRsN+qCDC+Q== Subject: Re: [PATCH] KVM: nVMX: remove unnecessary vmwrite from L2->L1 vmexit To: Liran Alon , Paolo Bonzini , linux-kernel@vger.kernel.org, kvm@vger.kernel.org Cc: jmattson@google.com References: <1514847495-29681-1-git-send-email-pbonzini@redhat.com> <5A4B551E.2020603@ORACLE.COM> From: Quan Xu Message-ID: <46aac22a-7ffd-c839-c203-ee68c502e20e@gmail.com> Date: Wed, 3 Jan 2018 14:32:28 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <5A4B551E.2020603@ORACLE.COM> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On 2018/01/02 17:47, Liran Alon wrote: > > > On 02/01/18 00:58, Paolo Bonzini wrote: >> The POSTED_INTR_NV field is constant (though it differs between the >> vmcs01 and >> vmcs02), there is no need to reload it on vmexit to L1. >> >> Signed-off-by: Paolo Bonzini >> --- >>   arch/x86/kvm/vmx.c | 3 --- >>   1 file changed, 3 deletions(-) >> >> diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c >> index e6223fe8faa1..1e184830a295 100644 >> --- a/arch/x86/kvm/vmx.c >> +++ b/arch/x86/kvm/vmx.c >> @@ -11610,9 +11610,6 @@ static void load_vmcs12_host_state(struct >> kvm_vcpu *vcpu, >>            */ >>           vmx_flush_tlb(vcpu, true); >>       } >> -    /* Restore posted intr vector. */ >> -    if (nested_cpu_has_posted_intr(vmcs12)) >> -        vmcs_write16(POSTED_INTR_NV, POSTED_INTR_VECTOR); >> >>       vmcs_write32(GUEST_SYSENTER_CS, vmcs12->host_ia32_sysenter_cs); >>       vmcs_writel(GUEST_SYSENTER_ESP, vmcs12->host_ia32_sysenter_esp); >> > > Reviewed-by: Liran Alon > > I would also add to commit message: > Fixes: 06a5524f091b ("KVM: nVMX: Fix posted intr delivery when vcpu is > in guest mode") > Reviewed-by: Quan Xu