Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751581AbeACHGU (ORCPT + 1 other); Wed, 3 Jan 2018 02:06:20 -0500 Received: from imap.thunk.org ([74.207.234.97]:45524 "EHLO imap.thunk.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751046AbeACHGS (ORCPT ); Wed, 3 Jan 2018 02:06:18 -0500 Date: Wed, 3 Jan 2018 02:05:56 -0500 From: Theodore Ts'o To: Byungchul Park Cc: Matthew Wilcox , Byungchul Park , Thomas Gleixner , Peter Zijlstra , Ingo Molnar , david@fromorbit.com, Linus Torvalds , Amir Goldstein , linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, oleg@redhat.com, kernel-team@lge.com, daniel@ffwll.ch Subject: Re: About the try to remove cross-release feature entirely by Ingo Message-ID: <20180103070556.GA22583@thunk.org> Mail-Followup-To: Theodore Ts'o , Byungchul Park , Matthew Wilcox , Byungchul Park , Thomas Gleixner , Peter Zijlstra , Ingo Molnar , david@fromorbit.com, Linus Torvalds , Amir Goldstein , linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, oleg@redhat.com, kernel-team@lge.com, daniel@ffwll.ch References: <20171229014736.GA10341@X58A-UD3R> <20171229035146.GA11757@thunk.org> <20171229072851.GA12235@X58A-UD3R> <20171230061624.GA27959@bombadil.infradead.org> <20171230154041.GB3366@thunk.org> <20171230204417.GF27959@bombadil.infradead.org> <20171230224028.GC3366@thunk.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.2 (2017-12-15) X-SA-Exim-Connect-IP: X-SA-Exim-Mail-From: tytso@thunk.org X-SA-Exim-Scanned: No (on imap.thunk.org); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On Wed, Jan 03, 2018 at 11:10:37AM +0900, Byungchul Park wrote: > > The point I was trying to drive home is that "all we have to do is > > just classify everything well or just invalidate the right lock > > Just to be sure, we don't have to invalidate lock objects at all but > a problematic waiter only. So essentially you are proposing that we have to play "whack-a-mole" as we find false positives, and where we may have to put in ad-hoc plumbing to only invalidate "a problematic waiter" when it's problematic --- or to entirely suppress the problematic waiter altogether. And in that case, a file system developer might be forced to invalidate a lock/"waiter"/"completion" in another subsystem. I will also remind you that doing this will trigger a checkpatch.pl *error*: ERROR("LOCKDEP", "lockdep_no_validate class is reserved for device->mutex.\n" . $herecurr); - Ted