Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751427AbeACH61 (ORCPT + 1 other); Wed, 3 Jan 2018 02:58:27 -0500 Received: from mail-it0-f65.google.com ([209.85.214.65]:35228 "EHLO mail-it0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751139AbeACH6Z (ORCPT ); Wed, 3 Jan 2018 02:58:25 -0500 X-Google-Smtp-Source: ACJfBovxW4dC2nlsE/CqZ+cJZzd2MzIoJ1fNR9Kxl/LRazaM9s/mDOrrsykfmBZjFYOcgomg94qEjDjSr0tjsFrN2C4= MIME-Version: 1.0 In-Reply-To: <1514899688-27844-3-git-send-email-Julia.Lawall@lip6.fr> References: <1514899688-27844-1-git-send-email-Julia.Lawall@lip6.fr> <1514899688-27844-3-git-send-email-Julia.Lawall@lip6.fr> From: Linus Walleij Date: Wed, 3 Jan 2018 08:58:24 +0100 Message-ID: Subject: Re: [PATCH 02/12] pinctrl: at91-pio4: account for const type of of_device_id.data To: Julia Lawall Cc: Ludovic Desroches , kernel-janitors@vger.kernel.org, Nicolas Ferre , Alexandre Belloni , Linux ARM , linux-gpio@vger.kernel.org, "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On Tue, Jan 2, 2018 at 2:27 PM, Julia Lawall wrote: > This driver creates a const structure that it stores in the data field > of an of_device_id array. > > Adding const to the declaration of the location that receives the > const value from the data field ensures that the compiler will > continue to check that the value is not modified. Furthermore, the > const-discarding cast on the extraction from the data field is no > longer needed. > > Done using Coccinelle. > > Signed-off-by: Julia Lawall Patch applied. Yours, Linus Walleij