Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751581AbeACH6x (ORCPT + 1 other); Wed, 3 Jan 2018 02:58:53 -0500 Received: from mail-ve1eur01on0062.outbound.protection.outlook.com ([104.47.1.62]:34944 "EHLO EUR01-VE1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751139AbeACH6t (ORCPT ); Wed, 3 Jan 2018 02:58:49 -0500 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=tariqt@mellanox.com; Subject: Re: [PATCH] ethernet: mlx4: Delete an error message for a failed memory allocation in five functions To: SF Markus Elfring , linux-rdma@vger.kernel.org, netdev@vger.kernel.org, Tariq Toukan Cc: LKML , kernel-janitors@vger.kernel.org References: <30191db0-4d99-0349-b66a-c7354ef90d50@users.sourceforge.net> From: Tariq Toukan Message-ID: <0fea8f2f-f8fc-ce2e-3d33-44227de3637a@mellanox.com> Date: Wed, 3 Jan 2018 09:58:39 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 MIME-Version: 1.0 In-Reply-To: <30191db0-4d99-0349-b66a-c7354ef90d50@users.sourceforge.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [193.47.165.251] X-ClientProxiedBy: AM5PR0502CA0009.eurprd05.prod.outlook.com (2603:10a6:203:91::19) To AM2PR05MB1139.eurprd05.prod.outlook.com (2a01:111:e400:844d::19) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 727af51f-bdf5-4ce3-6c32-08d5527fcf6e X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(48565401081)(5600026)(4604075)(2017052603307)(7153060);SRVR:AM2PR05MB1139; X-Microsoft-Exchange-Diagnostics: 1;AM2PR05MB1139;3:L+31RuOFHKV67vzErF8cCuRnseR18IShLHBwRJVhe4uwbGpJqEJesY4UHavL5WoTtdxtxOHcIoNKFDyQb5WOqGNXllQyABZc6pUqMvijNqSbzRtG+0xoD8LL72fge1+5h3gZ2SNyBtHyqznIkAhDS9GdNFZ9UyHKD623CrU00U3oxb5n/qpYt39nM5u61biQAZw9BIGqrnf7K3kB2WtXoIYpVle1GS/7/f0+z5HYPFyOHNeXhELwfm6OY+H9wUeu;25:iwInHCBP/sEz2ZL5jr+2JSPP8HpZsjYZ+AlCIFKqachgD8pIWwp8hLhYIqZNQqHQoR6PRtDV8Br+oL4RHblF/VS+oS5ts5NvzFYOLtepauOcmAmZTCUSoBzzuHZCMg7bhoa/UdqQfJjSg4pKOeG+CbGSO2cxlBQi72LqvIvN54ddU9fj8/4Qf2Zs8pzDjbX9vUOrtQnFyP3oqkxmTyNV/1YS+mXPA/RSa1g8kZpPU7eiV95VD4TgVXs7gFM82vHyj/ciHbq45v9bTUv8ylWjt5NM/vPQFJqmsrW1vePPuv4fAjKZWIe+/jir87rUgdrDSd68CTm78A28YRrXkvaXPw==;31:AZDFA3l/jvLq8eZ0uWX+pZte9UrJvC4ovB+Rq5CXAmWDHESq4wWSvVTZmbWsyNHQV1SGZAZRoaJ+zO3qlbShL0WoBrFMJRU+NM2Nfz8x7ju3NwgLCX6JlVrJIDSAsweo0O0RhfQ3vptAV/H0gqcvguLAWZaTTjENC2pgSZiTlhBQBXFIXV7fo25cMY7BNg+2R3JAtCJHeFGE1jJB9Ct9sNcza9vF1fFW/SSs7Yx83eQ= X-MS-TrafficTypeDiagnostic: AM2PR05MB1139: X-Microsoft-Exchange-Diagnostics: 1;AM2PR05MB1139;20:n5FpUXFO0aHvpI5rQnAdf0Bx4IDlXDdDimyqriD15T2Ss6UOWV7PinghlvUF+sPwfx1xphElR2J5wl0jpbpqidHy3CPIIIIvEzUwb4q09QyB35cSnxXME3NYtU9ibm9Ju62UpRXTDky97UgVZtT771TA2kXkYJ77FeTWMWHYHGwqI1nqcu+HR9ill0K1NDpaRACvq4AKHHxkOLTskt5ihnIxB+f4e7acdSk7fcFfVWVcncHCbxNtaYc95G8GCMbv4qGMLAQf+7YGgEQ4bwvICGgQjO4yBkSiUDR+ufiv+tkuNoFfK1KiBZKLT6elulqyK41xHbjzq8o7Qf7CbOBSRG3xTSDXvaowcJRqW4Q/YeHHXD4StSyyuMLlZhoZAynx2MCDPAiQ7i2TO7e7HUhUXeVkVz97WttqnEz9smaBNxi0ODmKL2Bs0h5cMTj9J0ExBlbas0UfCiZmVrW/BzH6iGHo/Ks86tkuyUP7PQd+kUPPlhEssDM//u4xCfWriv7X;4:TRyet8LYpc5LhADU6FAhS30ZmHPh6MvaCaZKMLcCRV0ZLHDC+/RWwv7JF8mLYTbUqQ3sMLhqri0SAwn1wh9MpKrLYWR9V6c7fzB+IZxVAMlKqK6+4vHuEKhSTG471ik8d+MyTge53YHYZ99GcNzwpL9bomYDcf/x1ssGhLbcy14aLXrE6fa1bebYuvH1Sd7xIsvW3j6EO2loA7x3RKPgKQ/gUWio2oXtwI4JJiv3OpRfamw3CyHeqtT3oL4QwLS4yPvZv+LcoAb0pd/BTSF7FTi+rHdiQSJBaE6s/U6AGW7OKWHEkjqEj5K01L1SHAfD X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(42262312472803); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040470)(2401047)(8121501046)(5005006)(3002001)(3231023)(944501075)(93006095)(93001095)(10201501046)(6055026)(6041268)(20161123562045)(20161123564045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(20161123558120)(6072148)(201708071742011);SRVR:AM2PR05MB1139;BCL:0;PCL:0;RULEID:(100000803101)(100110400095);SRVR:AM2PR05MB1139; X-Forefront-PRVS: 0541031FF6 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(6049001)(396003)(366004)(376002)(346002)(39380400002)(39860400002)(189003)(199004)(24454002)(105586002)(6486002)(86362001)(106356001)(229853002)(76176011)(4326008)(316002)(81166006)(31696002)(110136005)(50466002)(47776003)(16576012)(65806001)(58126008)(77096006)(67846002)(6246003)(8676002)(36756003)(25786009)(81156014)(66066001)(65956001)(2906002)(386003)(8936002)(83506002)(7736002)(53546011)(16526018)(305945005)(3846002)(6116002)(64126003)(15650500001)(2486003)(59450400001)(31686004)(230700001)(478600001)(6666003)(52116002)(68736007)(65826007)(53936002)(23676004)(2950100002)(52146003)(97736004)(5660300001);DIR:OUT;SFP:1101;SCL:1;SRVR:AM2PR05MB1139;H:[10.8.0.245];FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtBTTJQUjA1TUIxMTM5OzIzOjlHek55WFhWT2djT3dKNGkrWkhOTEJ0QXJj?= =?utf-8?B?L0NpK1VWZ3VhVWFZUkJGYjlMSXhVTncwbUkvTFlxMXMyM2Q0dzhQRWJqa01M?= =?utf-8?B?T2NOZDBYWS9pYmM4QVdCbkVPRXVlbENBY210dXJpTzZwU3dxUm9UNEc0RFdM?= =?utf-8?B?SGJydjBUSHZ3dEo2cVRiZ0ROcndlNGtJcU02NHAwQUlBQmorM21DSDYwMzc2?= =?utf-8?B?dHZmUXZnaGVkS1RkNFp5b0VwaURVNEVTRnRnM2lUbjlwL3FvekN3RFBFcGlC?= =?utf-8?B?bTBkWk9SZ2V6bkMyeDYvSU8wODE3U3hYQS94M01xTGVKOExlNGZlWmVJQm53?= =?utf-8?B?OHpxTUJoZGxvaEE0MEpTMHY0ajdEMDRNaEpRWEYrOURoNjltTUIzMmJ6ZnR6?= =?utf-8?B?eEJOWTJycHpaQlVXU3MzQXpmTThndjZqUDkrMW16bjd3dU0vYjgzU3JPWEVa?= =?utf-8?B?RDY3M1pTZEpKYjdFcS94eWRHcTBVVFJ4anRkZFBiQ1l2L3lVUjZRVk9lbXdZ?= =?utf-8?B?b0tlcmhRS0ZYOGcybTRIUUJ0clc1TmF4akxkSE9vUGZ0WXRNVVBKMnZ0Znkr?= =?utf-8?B?K0xFNFV4cEkwV0w1NWJ5WjlvWitLbnN5MGpuWVE2YjZSS21VTU9VcGtkL2F2?= =?utf-8?B?QnIzWWQyV3RYOCtuWTBjMzBvSHo2emZVMjhKT1NQNTlyODVJOFI3Zm1OQmFO?= =?utf-8?B?N2REOHM2NERLK3ErSC9HQjNkaGthcS9xTEFuMWthWndMSE5uY3JaUURSZ05n?= =?utf-8?B?MVBCT3Z2bVcyRGFIUjk5alorL0dlODNuVUhHOHRsUTJwK2RHUE1lcWJ5dndR?= =?utf-8?B?TWR4UmtYbUM2OWpwL0w3WEg4TXI5OTBkL1ZNWWZFRURQL2JyOUo1Sm1TV0pq?= =?utf-8?B?R3h2VmhFTlc4NjNBTDh5cHR1aW1wNGM1Q0hhOHQ0Szg5TXV3MVF4T2gvdmRJ?= =?utf-8?B?eW9tdzI4VXNaellzaUJzdHMxTngwbVNOWUJ6d3dtaWFNeHNOTmxBN1ZJTThE?= =?utf-8?B?dlR0MDE1YXpTQm5Sang2V0x5R0JReE5ub3ZMaUZ0bFBvZGozU3lyN29VVnNh?= =?utf-8?B?a1E0MUM5Z1N3alhqb1hmSUZKVHdTYXlIcVZwUnZMTDJqdURGK1J6d29YLzZh?= =?utf-8?B?aVpOYXJCWmdtVnZObTNLclI1MzFocldJd2JyOWdnTi9LZ2NBaEtsdDZGbmMw?= =?utf-8?B?TSt1TzhBNld4NW5BUkpTemJ1bGRaM2RDUkRXU0oweTlXOXVwem0wdHF1UEF3?= =?utf-8?B?R21hUjBQQkJTWjYyRDZtUGJnK1JSR284NXc5aFlMQm5icXNLN0FZMEJ2eTNw?= =?utf-8?B?UUZVOXRUS1k5TDk4dk1Gdk1PVHozWDRyZnFJNUZzc2dLdjJCTDI0RXhVU2xj?= =?utf-8?B?SXJ1anVpd1d3YjRGdkU4MW5EZ1hRVlo1NHRlay9jRU1Yb3RoTE1yTURFYWN0?= =?utf-8?B?T2NyWjVNaVBiZGdRWEpQMHNBNHJxNkRaNlR4cFRUWU1xd1dUWDVlZjRkUTJX?= =?utf-8?B?OUFHLy9nczVNS1ZYU2NHYVNCSkRJUkVSMmNMMThiRTBLaE1WdXA3MXUvbkdm?= =?utf-8?B?dFBxZTdEVWsyVWxBQlFnTUFwK1JaZEVROXVpcFQybzdvSFFwYTFuZU1qdjVh?= =?utf-8?B?NkpNb1pSclU5eTY3eGRHcWhMdDlabjV0WktycHA5TkFDRndOdGxOTnE0bEVM?= =?utf-8?B?bUNlU3UwNXlzUmhTY0hsNnN3VUlxSmlGV2lkb0FPOXFycGp2UFl3OTdUV1RY?= =?utf-8?B?SThtZTFWT3A3Nk84dFREM2FOOXB6ck9mdm1IWDBDOGkrb2xFa2N0dGpYa1lP?= =?utf-8?B?SHhvZms0NUZWOW5JY0NFZ0NrTjMwbkJJZVZIeGt5Vkx4SVlSY3VRUDRFUGs5?= =?utf-8?B?V2hvOGtNL01rZ095UlRSSnFwMGMwUzhQQW1jQlJ6SUF1RSsyNVB1dmJ0L2Vh?= =?utf-8?B?OFlPNk1yNy9RPT0=?= X-Microsoft-Exchange-Diagnostics: 1;AM2PR05MB1139;6:gqgUAdyTq6y58p0F+T7/SMA8CJf6lGCGxmCSzOD0l1MoILDz3xbZO9Fmpl9T/lv7oHLPwcUSjHmexc38U+UcS5YuYNczOMSx3c9VBlMSJ0ZSFL1tJtuJBO2C3OM5YS2c5mKg3fpLeY6ENAPghwGf9FUA91ea1UpL5uqetWFHKUHXEEmNgKqU1AwFajDuoQy3w6p8ADvQsST6elYBmdWa+sdgfgg5z4e1e6VNk3B5LWqLsv9krdhOE7jngnL1x7UBNp0UoDPEz+d2pI+batWuKvVTDTQKiJaXVHcN3ojT5Ea4fMfQT2VG+gCkGhFrXbTDewCK/v8IH2pFSdzTSfHzJ6GdmDLKj24FmTxaqd+6qHo=;5:XpOfT2URM0wD7k6cB0/oxTVjOCx64LyvKulx8NKZHiCsG6JelhAzLcLDES7Fo0kEEJqVatYlemuVjJUdHHReDmC2qRzRvRisW/nkqoWjmSzoJ8jZ3XqE6e7UqM9IaT0mUepmMK6zdP3Izei3NRajcSHzMjjxxgAYjrmo4iOYj0I=;24:zB8RmJLv/LHf8F2pTfXKF/pCwFJnU4bvwhcDRfUc106nZcxwaiZ818EcTdzbdIeUEPBumqCDvkSKOXUrMgzpQUhUstVfg0ys8X27qiupgGQ=;7:PsHbf4jWOACy5uUT84Q7KOjRS/ySaVw3ME6AYyQ6qAiQg9+GA8Y9xODe00exOVDRIJMzhs1YqnjC3i81IwapZbXgrXfeZva9QYBzc1d4+WMyH9trMIRaAUyxW0/jGmqQt1b5Icr/HBoZ/ii0/Ts+5Q6v0SU6pMlPGwy61bT+V2mQjQgv9PCbrNuQdOOCvie8MBpnhDcfoK2WWcxP2+jPe0wEVMaNIU1EsXlU5vQ817e9w4jJqQq3Um4rnD2AxjCo SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Jan 2018 07:58:43.1612 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 727af51f-bdf5-4ce3-6c32-08d5527fcf6e X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM2PR05MB1139 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On 01/01/2018 10:46 PM, SF Markus Elfring wrote: > From: Markus Elfring > Date: Mon, 1 Jan 2018 21:42:27 +0100 > > Omit an extra message for a memory allocation failure in these functions. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring > --- Is this an issue? Why? What is your motivation? These are error messages, very informative, appear only upon errors, and in control flow.