Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751459AbeACIGE (ORCPT + 1 other); Wed, 3 Jan 2018 03:06:04 -0500 Received: from mail2-relais-roc.national.inria.fr ([192.134.164.83]:58987 "EHLO mail2-relais-roc.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750839AbeACIGD (ORCPT ); Wed, 3 Jan 2018 03:06:03 -0500 X-IronPort-AV: E=Sophos;i="5.45,500,1508796000"; d="scan'208";a="307478728" Date: Wed, 3 Jan 2018 09:06:01 +0100 (CET) From: Julia Lawall X-X-Sender: jll@hadrien To: Tariq Toukan cc: SF Markus Elfring , linux-rdma@vger.kernel.org, netdev@vger.kernel.org, LKML , kernel-janitors@vger.kernel.org Subject: Re: [PATCH] ethernet: mlx4: Delete an error message for a failed memory allocation in five functions In-Reply-To: <0fea8f2f-f8fc-ce2e-3d33-44227de3637a@mellanox.com> Message-ID: References: <30191db0-4d99-0349-b66a-c7354ef90d50@users.sourceforge.net> <0fea8f2f-f8fc-ce2e-3d33-44227de3637a@mellanox.com> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On Wed, 3 Jan 2018, Tariq Toukan wrote: > > > On 01/01/2018 10:46 PM, SF Markus Elfring wrote: > > From: Markus Elfring > > Date: Mon, 1 Jan 2018 21:42:27 +0100 > > > > Omit an extra message for a memory allocation failure in these functions. > > > > This issue was detected by using the Coccinelle software. > > > > Signed-off-by: Markus Elfring > > --- > > Is this an issue? Why? What is your motivation? > These are error messages, very informative, appear only upon errors, and in > control flow. Strings take up space. Since there is a backtrace on an out of memory problem, if the string does not provide any more information than the position of the call, then there is not much added value. I don't know what was the string in this case. If it provides some additional information, then it would be reasonable to keep it. julia > -- > To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >