Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752712AbeACMXu (ORCPT <rfc822;ralf@linux-mips.org> + 1 other);
        Wed, 3 Jan 2018 07:23:50 -0500
Received: from fllnx209.ext.ti.com ([198.47.19.16]:65371 "EHLO
        fllnx209.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1752226AbeACMXs (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 3 Jan 2018 07:23:48 -0500
Subject: Re: [PATCH v6 1/6] can: dev: Add support for limiting configured
 bitrate
To: Marc Kleine-Budde <mkl@pengutronix.de>, <wg@grandegger.com>,
        <robh+dt@kernel.org>, <mark.rutland@arm.com>
CC: <linux-can@vger.kernel.org>, <netdev@vger.kernel.org>,
        <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <nsekhar@ti.com>, <fcooper@ti.com>, <robh@kernel.org>,
        <Wenyou.Yang@microchip.com>, <sergei.shtylyov@cogentembedded.com>
References: <1513949488-13026-1-git-send-email-faiz_abbas@ti.com>
 <1513949488-13026-2-git-send-email-faiz_abbas@ti.com>
 <8d973da8-df40-e37e-377f-50666db382fe@pengutronix.de>
From: Faiz Abbas <faiz_abbas@ti.com>
Message-ID: <5dadca68-f8ae-e708-5a5f-5d2a8876cf40@ti.com>
Date: Wed, 3 Jan 2018 17:51:40 +0530
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.4.0
MIME-Version: 1.0
In-Reply-To: <8d973da8-df40-e37e-377f-50666db382fe@pengutronix.de>
Content-Type: text/plain; charset="utf-8"
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>

Hi,

On Tuesday 02 January 2018 09:45 PM, Marc Kleine-Budde wrote:
> On 12/22/2017 02:31 PM, Faiz Abbas wrote:
>> From: Franklin S Cooper Jr <fcooper@ti.com>
>>
>> Various CAN or CAN-FD IP may be able to run at a faster rate than
>> what the transceiver the CAN node is connected to. This can lead to
>> unexpected errors. However, CAN transceivers typically have fixed
>> limitations and provide no means to discover these limitations at
>> runtime. Therefore, add support for a can-transceiver node that
>> can be reused by other CAN peripheral drivers to determine for both
>> CAN and CAN-FD what the max bitrate that can be used. If the user
>> tries to configure CAN to pass these maximum bitrates it will throw
>> an error.
> 
> Please add support to read the maximum bitrate via netlink. Have a look
> at 12a6075cabc0 ("can: dev: add CAN interface termination API"). I think
> you need to extend the following functions: can_get_size() and
> can_fill_info().

Will add in the next version.

Thanks,
Faiz

> 
> Marc
>