Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752770AbeACMtf (ORCPT + 1 other); Wed, 3 Jan 2018 07:49:35 -0500 Received: from mail-wr0-f194.google.com ([209.85.128.194]:46484 "EHLO mail-wr0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752051AbeACMtd (ORCPT ); Wed, 3 Jan 2018 07:49:33 -0500 X-Google-Smtp-Source: ACJfBotLX8/U7tZGr66xvEILElCsO5IMvt0du4P1C8A2BreWFT2zN+5do21XZ5w7rNqYpThZ/X1jGBL6AxeTGH1G1VQ= MIME-Version: 1.0 In-Reply-To: References: <1514474364-32169-1-git-send-email-mastichi@gmail.com> From: Dmitry Mastykin Date: Wed, 3 Jan 2018 15:49:31 +0300 Message-ID: Subject: Re: [PATCH] pinctrl: mcp23s08: fix irq setup order To: Linus Walleij Cc: Sebastian Reichel , Phil Reid , linux-gpio@vger.kernel.org, "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On Tue, Jan 2, 2018 at 12:10 PM, Linus Walleij wrote: > > Patch applied, albeit for devel. > > Should it be tagged for stable or go into fixes? > Thank you very much, Linus! About tags, please do as it convenient for you. Kind regards, Dmitry > On Thu, Dec 28, 2017 at 4:19 PM, Dmitry Mastykin wrote: > >> When using mcp23s08 module with gpio-keys, often (50% of boots) >> it fails to get irq numbers with message: >> "gpio-keys keys: Unable to get irq number for GPIO 0, error -6". >> Seems that irqs must be setup before devm_gpiochip_add_data(). >> >> Signed-off-by: Dmitry Mastykin