Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752475AbeACOAy (ORCPT + 1 other); Wed, 3 Jan 2018 09:00:54 -0500 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:50132 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751507AbeACOAx (ORCPT ); Wed, 3 Jan 2018 09:00:53 -0500 Subject: Re: [PATCH 2/3] mm, migrate: remove reason argument from new_page_t To: Michal Hocko , Andrew Morton References: <20180103082555.14592-1-mhocko@kernel.org> <20180103082555.14592-3-mhocko@kernel.org> Cc: Zi Yan , Naoya Horiguchi , "Kirill A. Shutemov" , Vlastimil Babka , Andrea Reale , Anshuman Khandual , linux-mm@kvack.org, LKML , Michal Hocko From: Anshuman Khandual Date: Wed, 3 Jan 2018 19:30:38 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: <20180103082555.14592-3-mhocko@kernel.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 x-cbid: 18010314-0012-0000-0000-0000059F3C00 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 18010314-0013-0000-0000-0000191A86A4 Message-Id: X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2018-01-03_10:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 impostorscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1709140000 definitions=main-1801030197 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On 01/03/2018 01:55 PM, Michal Hocko wrote: > From: Michal Hocko > > No allocation callback is using this argument anymore. new_page_node > used to use this parameter to convey node_id resp. migration error > up to move_pages code (do_move_page_to_node_array). The error status > never made it into the final status field and we have a better way > to communicate node id to the status field now. All other allocation > callbacks simply ignored the argument so we can drop it finally. There is a migrate_pages() call in powerpc which needs to be changed as well. It was failing the build on powerpc. diff --git a/arch/powerpc/mm/mmu_context_iommu.c b/arch/powerpc/mm/mmu_context_iommu.c index e0a2d8e..91ee223 100644 --- a/arch/powerpc/mm/mmu_context_iommu.c +++ b/arch/powerpc/mm/mmu_context_iommu.c @@ -75,8 +75,7 @@ bool mm_iommu_preregistered(struct mm_struct *mm) /* * Taken from alloc_migrate_target with changes to remove CMA allocations */ -struct page *new_iommu_non_cma_page(struct page *page, unsigned long private, - int **resultp) +struct page *new_iommu_non_cma_page(struct page *page, unsigned long private) { gfp_t gfp_mask = GFP_USER; struct page *new_page;